From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 188B8B2B6 for ; Wed, 6 Apr 2022 13:58:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D4F52A6C6 for ; Wed, 6 Apr 2022 13:58:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3D8B22A5AB for ; Wed, 6 Apr 2022 13:58:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 13A2241B98 for ; Wed, 6 Apr 2022 13:58:06 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Wed, 6 Apr 2022 13:57:30 +0200 Message-Id: <20220406115734.898714-14-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220406115734.898714-1-o.bektas@proxmox.com> References: <20220406115734.898714-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.534 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 manager 13/17] ui: lxc features: check for SU instead of 'root@pam' X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 11:58:42 -0000 Signed-off-by: Oguz Bektas --- v2->v3: * added new, previously the editor was still double-clickable eventhough the 'edit' button was grayed out * check for SU instead of root@pam www/manager6/lxc/Options.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index d0a53fc7..7aa18447 100644 --- a/www/manager6/lxc/Options.js +++ b/www/manager6/lxc/Options.js @@ -175,9 +175,13 @@ Ext.define('PVE.lxc.Options', { if (key === 'features') { let unprivileged = me.getStore().getById('unprivileged').data.value; - let root = Proxmox.UserName === 'root@pam'; + let superuser = caps.vms['SuperUser']; // eslint-disable-line let vmalloc = caps.vms['VM.Allocate']; - edit_btn.setDisabled(!(root || (vmalloc && unprivileged))); + let disabled = !(superuser || (vmalloc && unprivileged)); + edit_btn.setDisabled(disabled); + if (disabled) { + rowdef.editor = undefined; + } } else { edit_btn.setDisabled(!rowdef.editor); } -- 2.30.2