From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F1E73B22C for ; Wed, 6 Apr 2022 13:58:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E7A82A5DA for ; Wed, 6 Apr 2022 13:58:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A824C2A513 for ; Wed, 6 Apr 2022 13:58:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 68C334259F for ; Wed, 6 Apr 2022 13:58:04 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Wed, 6 Apr 2022 13:57:27 +0200 Message-Id: <20220406115734.898714-11-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220406115734.898714-1-o.bektas@proxmox.com> References: <20220406115734.898714-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.547 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 manager 10/17] api: vzdump: allow SUs to use 'bwlimit' and 'ionice' parameters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 11:58:09 -0000 Signed-off-by: Oguz Bektas --- v2->v3: * no changes PVE/API2/VZDump.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/PVE/API2/VZDump.pm b/PVE/API2/VZDump.pm index 13b6cd46..99366212 100644 --- a/PVE/API2/VZDump.pm +++ b/PVE/API2/VZDump.pm @@ -27,7 +27,7 @@ __PACKAGE__->register_method ({ permissions => { description => "The user needs 'VM.Backup' permissions on any VM, and 'Datastore.AllocateSpace'" ." on the backup storage. The 'maxfiles', 'prune-backups', 'tmpdir', 'dumpdir', 'script'," - ." 'bwlimit' and 'ionice' parameters are restricted to the 'root\@pam' user.", + ." 'bwlimit' and 'ionice' parameters are restricted to the superusers.", user => 'all', }, protected => 1, @@ -52,6 +52,8 @@ __PACKAGE__->register_method ({ my $nodename = PVE::INotify::nodename(); + my $is_superuser = $user eq 'root@pam' || $rpcenv->check($user, "/", ['SuperUser'], 1); + if ($rpcenv->{type} ne 'cli') { raise_param_exc({ node => "option is only allowed on the command line interface."}) if $param->{node} && $param->{node} ne $nodename; @@ -61,8 +63,8 @@ __PACKAGE__->register_method ({ } foreach my $key (qw(maxfiles prune-backups tmpdir dumpdir script bwlimit ionice)) { - raise_param_exc({ $key => "Only root may set this option."}) - if defined($param->{$key}) && ($user ne 'root@pam'); + raise_param_exc({ $key => "Only superusers may set this option."}) + if defined($param->{$key}) && !$is_superuser; } PVE::VZDump::verify_vzdump_parameters($param, 1); -- 2.30.2