From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1C536B22E for ; Wed, 6 Apr 2022 13:58:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A9AEC2A5EC for ; Wed, 6 Apr 2022 13:58:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D8C422A51F for ; Wed, 6 Apr 2022 13:58:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8418F41CAC for ; Wed, 6 Apr 2022 13:58:04 +0200 (CEST) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Wed, 6 Apr 2022 13:57:26 +0200 Message-Id: <20220406115734.898714-10-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220406115734.898714-1-o.bektas@proxmox.com> References: <20220406115734.898714-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.544 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 manager 09/17] api: backup: allow SUs to use 'tmpdir', 'dumpdir' and 'script' options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 11:58:09 -0000 previously limited to root@pam; we can allow SUs to use these options if they have the privilege on the whole API path. Signed-off-by: Oguz Bektas --- v2->v3: * change comment for SU check PVE/API2/Backup.pm | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 5d36789a..286996b5 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2/Backup.pm @@ -41,10 +41,13 @@ my $vzdump_job_id_prop = { my $assert_param_permission = sub { my ($param, $user) = @_; - return if $user eq 'root@pam'; # always OK + return if $user eq 'root@pam'; # root@pam always OK + + my $rpcenv = PVE::RPCEnvironment::get(); + return if $rpcenv->check($user, "/", ['SuperUser'], 1); # SuperUser on /, always OK for my $key (qw(tmpdir dumpdir script)) { - raise_param_exc({ $key => "Only root may set this option."}) if exists $param->{$key}; + raise_param_exc({ $key => "Only superusers may set this option."}) if exists $param->{$key}; } }; @@ -143,7 +146,7 @@ __PACKAGE__->register_method({ description => "Create new vzdump backup job.", permissions => { check => ['perm', '/', ['Sys.Modify']], - description => "The 'tmpdir', 'dumpdir' and 'script' parameters are additionally restricted to the 'root\@pam' user.", + description => "The 'tmpdir', 'dumpdir' and 'script' parameters are additionally restricted to superusers.", }, parameters => { additionalProperties => 0, @@ -345,7 +348,7 @@ __PACKAGE__->register_method({ description => "Update vzdump backup job definition.", permissions => { check => ['perm', '/', ['Sys.Modify']], - description => "The 'tmpdir', 'dumpdir' and 'script' parameters are additionally restricted to the 'root\@pam' user.", + description => "The 'tmpdir', 'dumpdir' and 'script' parameters are additionally restricted to superusers.", }, parameters => { additionalProperties => 0, -- 2.30.2