From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7A21CAE49 for ; Wed, 6 Apr 2022 10:04:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 066692715B for ; Wed, 6 Apr 2022 10:04:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3877E270BD for ; Wed, 6 Apr 2022 10:04:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0601C42949 for ; Wed, 6 Apr 2022 10:04:37 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 6 Apr 2022 10:04:00 +0200 Message-Id: <20220406080416.66227-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220406080416.66227-1-f.ebner@proxmox.com> References: <20220406080416.66227-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.112 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v10 manager 03/19] ui: HD edit: move advanced options into a dedicated tab X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 08:04:39 -0000 Signed-off-by: Fabian Ebner --- www/manager6/qemu/HDEdit.js | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index 89620e7f..92e6d116 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -170,8 +170,6 @@ Ext.define('PVE.qemu.HDInputPanel', { me.down('#hdimage').setStorage(undefined, nodename); }, - hasAdvanced: true, - initComponent: function() { var me = this; @@ -180,9 +178,6 @@ Ext.define('PVE.qemu.HDInputPanel', { let column1 = []; let column2 = []; - let advancedColumn1 = []; - let advancedColumn2 = []; - if (!me.confid || me.unused) { me.bussel = Ext.create('PVE.form.ControllerSelector', { vmconfig: me.vmconfig, @@ -251,7 +246,7 @@ Ext.define('PVE.qemu.HDInputPanel', { }, ); - advancedColumn1.push( + let optionsColumn1 = [ { xtype: 'proxmoxcheckbox', fieldLabel: gettext('SSD emulation'), @@ -280,9 +275,9 @@ Ext.define('PVE.qemu.HDInputPanel', { disabled: '{!isVirtIO && !isSCSI}', }, }, - ); + ]; - advancedColumn2.push( + let optionsColumn2 = [ { xtype: 'proxmoxcheckbox', fieldLabel: gettext('Backup'), @@ -311,7 +306,7 @@ Ext.define('PVE.qemu.HDInputPanel', { ['threads', 'threads'], ], }, - ); + ]; let labelWidth = 140; @@ -403,21 +398,22 @@ Ext.define('PVE.qemu.HDInputPanel', { { title: gettext('Disk'), xtype: 'inputpanel', - reference: 'diskpanel', column1, column2, - advancedColumn1, - advancedColumn2, - showAdvanced: me.showAdvanced, + getValues: () => ({}), + }, + { + title: gettext('Options'), + xtype: 'inputpanel', + column1: optionsColumn1, + column2: optionsColumn2, getValues: () => ({}), }, { title: gettext('Bandwidth'), xtype: 'inputpanel', - reference: 'bwpanel', column1: bwColumn1, column2: bwColumn2, - showAdvanced: me.showAdvanced, getValues: () => ({}), }, ], @@ -426,11 +422,6 @@ Ext.define('PVE.qemu.HDInputPanel', { me.callParent(); }, - - setAdvancedVisible: function(visible) { - this.lookup('diskpanel').setAdvancedVisible(visible); - this.lookup('bwpanel').setAdvancedVisible(visible); - }, }); Ext.define('PVE.qemu.HDEdit', { -- 2.30.2