From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E31CBAFA1 for ; Wed, 6 Apr 2022 10:05:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DA40B270B4 for ; Wed, 6 Apr 2022 10:04:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B9722270A2 for ; Wed, 6 Apr 2022 10:04:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9233941FA4 for ; Wed, 6 Apr 2022 10:04:35 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 6 Apr 2022 10:03:59 +0200 Message-Id: <20220406080416.66227-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220406080416.66227-1-f.ebner@proxmox.com> References: <20220406080416.66227-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.112 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v10 manager 02/19] ui: HD edit: get rid of unneeded binding for backup checkbox X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 08:05:06 -0000 In preparation to move the advanced options to their own tab, where the value would not be updated until the component is rendered, which might not happen before submitting. Signed-off-by: Fabian Ebner --- www/manager6/qemu/HDEdit.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/www/manager6/qemu/HDEdit.js b/www/manager6/qemu/HDEdit.js index c643ee73..89620e7f 100644 --- a/www/manager6/qemu/HDEdit.js +++ b/www/manager6/qemu/HDEdit.js @@ -57,9 +57,7 @@ Ext.define('PVE.qemu.HDInputPanel', { init: function(view) { var vm = this.getViewModel(); - if (view.isCreate) { - vm.set('isIncludedInBackup', true); - } + if (view.confid) { vm.set('isSCSI', view.confid.match(/^scsi/)); vm.set('isVirtIO', view.confid.match(/^virtio/)); @@ -293,9 +291,7 @@ Ext.define('PVE.qemu.HDInputPanel', { 'data-qtip': gettext('Include volume in backup job'), }, name: 'backup', - bind: { - value: '{isIncludedInBackup}', - }, + value: me.isCreate, }, { xtype: 'proxmoxcheckbox', -- 2.30.2