From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5AB6FAECC for ; Wed, 6 Apr 2022 10:04:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8293727313 for ; Wed, 6 Apr 2022 10:04:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E1A362728E for ; Wed, 6 Apr 2022 10:04:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B42E4277A for ; Wed, 6 Apr 2022 10:04:41 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 6 Apr 2022 10:04:14 +0200 Message-Id: <20220406080416.66227-18-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220406080416.66227-1-f.ebner@proxmox.com> References: <20220406080416.66227-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.110 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v10 manager 17/19] ui: qemu: memory edit: expose setMemory outside the controller X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 08:04:47 -0000 In preparation to add a 'value' argument, because when the controller calls the function, the panel is passed as the first argument. And for convenience when calling from outside the class. Signed-off-by: Fabian Ebner --- www/manager6/qemu/MemoryEdit.js | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/www/manager6/qemu/MemoryEdit.js b/www/manager6/qemu/MemoryEdit.js index 5e91dc9b..0d2cd8b0 100644 --- a/www/manager6/qemu/MemoryEdit.js +++ b/www/manager6/qemu/MemoryEdit.js @@ -17,20 +17,25 @@ Ext.define('PVE.qemu.MemoryInputPanel', { }, setMemory: function() { - let me = this; - let view = me.getView(), viewModel = me.getViewModel(); - if (view.insideWizard) { - let memory = view.down('pveMemoryField[name=memory]'); - // NOTE: we only set memory but that then sets balloon in its change handler - if (viewModel.get('current.ostype') === 'win11') { - memory.setValue('4096'); - } else { - memory.setValue('2048'); - } - } + this.getView().setMemory(); }, }, + setMemory: function() { + let me = this; + let viewModel = me.getViewModel(); + + if (me.insideWizard) { + let memory = me.down('pveMemoryField[name=memory]'); + // NOTE: we only set memory but that then sets balloon in its change handler + if (viewModel.get('current.ostype') === 'win11') { + memory.setValue('4096'); + } else { + memory.setValue('2048'); + } + } + }, + onGetValues: function(values) { var me = this; -- 2.30.2