From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BD37196EF for ; Fri, 1 Apr 2022 11:44:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B477C24E4E for ; Fri, 1 Apr 2022 11:44:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E332D24E45 for ; Fri, 1 Apr 2022 11:44:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B05AB46F61 for ; Fri, 1 Apr 2022 11:44:28 +0200 (CEST) From: Mira Limbeck To: pve-devel@lists.proxmox.com Date: Fri, 1 Apr 2022 11:44:25 +0200 Message-Id: <20220401094425.158181-1-m.limbeck@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.198 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KAM_SHORT 0.001 Use of a URL Shortener for very short URL NO_DNS_FOR_FROM 0.001 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 proxmox-openid-rs] fix Open ID with Azure as provider X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 09:44:29 -0000 Azure doesn't accept `Transfer-Encoding: chunked` on their token endpoint, but with the switch to ureq we always send requests with this set. Fix by switching to `Content-Length` in the header instead. ureq only sets `Transfer-Encoding: chunked` when the body length is not known beforehand, which is the case when using `send`. See https://docs.rs/ureq/2.4.0/ureq/index.html#content-length-and-transfer-encoding See https://forum.proxmox.com/threads/openid-401-with-azure-ad.105892/ for the issue. Signed-off-by: Mira Limbeck --- v3: - fixed link in inline comment v2: - added inline comment - removed the unnecessary `let bytes = ...` line - changed link in commit message to versioned docs.rs probably also fixes https://bugzilla.proxmox.com/show_bug.cgi?id=3916, but I could only reproduce this exact error message with Azure until now. src/http_client.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/http_client.rs b/src/http_client.rs index a2bf6ee..e391421 100644 --- a/src/http_client.rs +++ b/src/http_client.rs @@ -75,7 +75,10 @@ pub fn http_client(request: HttpRequest) -> Result { } let response = if let Method::POST = request.method { - req.send(&*request.body) + // send_bytes makes sure that Content-Length is set. This is important, because some + // endpoints don't accept `Transfer-Encoding: chunked`, which would otherwise be set. + // see https://docs.rs/ureq/2.4.0/ureq/index.html#content-length-and-transfer-encoding + req.send_bytes(request.body.as_slice()) } else { req.call() } -- 2.30.2