From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DE8F78D34 for ; Wed, 30 Mar 2022 12:25:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CA5D86D9E for ; Wed, 30 Mar 2022 12:24:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5E2F46D94 for ; Wed, 30 Mar 2022 12:24:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 356D14595E for ; Wed, 30 Mar 2022 12:24:42 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 30 Mar 2022 12:24:30 +0200 Message-Id: <20220330102437.46955-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220330102437.46955-1-f.ebner@proxmox.com> References: <20220330102437.46955-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 storage 3/6] check volume access: allow for images/rootdir if user has VM.Config.Disk X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 10:25:13 -0000 Listing guest images should not require Datastore.Allocate in this case. In preparation for adding disk import to the GUI. Signed-off-by: Fabian Ebner --- Changes from v1: * Also check for Datastore.Audit privilege. PVE/Storage.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 0349564..a864c33 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -488,6 +488,9 @@ sub check_volume_access { } elsif ($vtype eq 'backup' && $ownervm) { $rpcenv->check($user, "/storage/$sid", ['Datastore.AllocateSpace']); $rpcenv->check($user, "/vms/$ownervm", ['VM.Backup']); + } elsif (($vtype eq 'images' || $vtype eq 'rootdir') && $ownervm) { + $rpcenv->check($user, "/storage/$sid", ['Datastore.Audit']); + $rpcenv->check($user, "/vms/$ownervm", ['VM.Config.Disk']); } else { die "missing privileges to access $volid\n"; } -- 2.30.2