From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E83088CC6 for ; Wed, 30 Mar 2022 12:24:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C78B96DD4 for ; Wed, 30 Mar 2022 12:24:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DDDC56DA8 for ; Wed, 30 Mar 2022 12:24:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ADA6F4595C for ; Wed, 30 Mar 2022 12:24:42 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 30 Mar 2022 12:24:29 +0200 Message-Id: <20220330102437.46955-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220330102437.46955-1-f.ebner@proxmox.com> References: <20220330102437.46955-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 storage 2/6] check volume access: always allow with Datastore.Allocate privilege X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 10:24:44 -0000 Such users are supposed to be administrators of the storage, but previously, access to backups was not allowed when not also having VM.Backup. Suggested-by: Fabian Grünbichler Signed-off-by: Fabian Ebner --- New in v2. Technically, a breaking change for pve-manager, because a user without VM.Backup privilege can now extract the guest config. PVE/Storage.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 6112991..0349564 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -477,6 +477,8 @@ sub check_volume_access { my ($sid, $volname) = parse_volume_id($volid, 1); if ($sid) { + return if $rpcenv->check($user, "/storage/$sid", ['Datastore.Allocate'], 1); + my ($vtype, undef, $ownervm) = parse_volname($cfg, $volid); if ($vtype eq 'iso' || $vtype eq 'vztmpl') { # require at least read access to storage, (custom) templates/ISOs could be sensitive @@ -487,8 +489,7 @@ sub check_volume_access { $rpcenv->check($user, "/storage/$sid", ['Datastore.AllocateSpace']); $rpcenv->check($user, "/vms/$ownervm", ['VM.Backup']); } else { - # allow if we are Datastore administrator - $rpcenv->check($user, "/storage/$sid", ['Datastore.Allocate']); + die "missing privileges to access $volid\n"; } } else { die "Only root can pass arbitrary filesystem paths." -- 2.30.2