From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5373C8CE4 for ; Wed, 30 Mar 2022 12:25:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 492F66D93 for ; Wed, 30 Mar 2022 12:24:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C95676D81 for ; Wed, 30 Mar 2022 12:24:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 98A434595E for ; Wed, 30 Mar 2022 12:24:41 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 30 Mar 2022 12:24:28 +0200 Message-Id: <20220330102437.46955-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220330102437.46955-1-f.ebner@proxmox.com> References: <20220330102437.46955-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 storage 1/6] pvesm: extract config: check for VM.Backup privilege X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 10:25:12 -0000 In preparation to have check_volume_access() always allow access for users with Datastore.Allocate privilege. As to not automatically give all such users permission to extract the config too. Signed-off-by: Fabian Ebner --- New in v2. PVE/CLI/pvesm.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 190de91..1daed71 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -172,6 +172,11 @@ __PACKAGE__->register_method ({ my $storage_cfg = PVE::Storage::config(); PVE::Storage::check_volume_access($rpcenv, $authuser, $storage_cfg, undef, $volume); + if (PVE::Storage::parse_volume_id($volume, 1)) { + my (undef, undef, $ownervm) = PVE::Storage::parse_volname($storage_cfg, $volume); + $rpcenv->check($authuser, "/vms/$ownervm", ['VM.Backup']); + } + my $config_raw = PVE::Storage::extract_vzdump_config($storage_cfg, $volume); print "$config_raw\n"; -- 2.30.2