From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5780E8D22 for ; Wed, 30 Mar 2022 12:25:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 351B46E43 for ; Wed, 30 Mar 2022 12:24:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E339A6E05 for ; Wed, 30 Mar 2022 12:24:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B201542DF5 for ; Wed, 30 Mar 2022 12:24:44 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 30 Mar 2022 12:24:37 +0200 Message-Id: <20220330102437.46955-12-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220330102437.46955-1-f.ebner@proxmox.com> References: <20220330102437.46955-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.114 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 qemu-server 1/1] api: create/modify: add content type checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 10:25:12 -0000 Signed-off-by: Fabian Ebner --- No changes from v1. PVE/API2/Qemu.pm | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index cb6973f1..1dd0cf28 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -104,7 +104,14 @@ my $check_storage_access = sub { raise_param_exc({ storage => "storage '$storeid' does not support vm images"}) if !$scfg->{content}->{images}; } else { - PVE::Storage::check_volume_access($rpcenv, $authuser, $storecfg, $vmid, $volid); + PVE::Storage::check_volume_access( + $rpcenv, + $authuser, + $storecfg, + $vmid, + $volid, + 'images', + ); } }); @@ -230,7 +237,14 @@ my $create_disks = sub { delete $disk->{format}; # no longer needed $res->{$ds} = PVE::QemuServer::print_drive($disk); } else { - PVE::Storage::check_volume_access($rpcenv, $authuser, $storecfg, $vmid, $volid); + PVE::Storage::check_volume_access( + $rpcenv, + $authuser, + $storecfg, + $vmid, + $volid, + 'images', + ); PVE::Storage::activate_volumes($storecfg, [ $volid ]) if $storeid; @@ -645,7 +659,14 @@ __PACKAGE__->register_method({ die "pipe requires cli environment\n" if $rpcenv->{type} ne 'cli'; $archive = { type => 'pipe' }; } else { - PVE::Storage::check_volume_access($rpcenv, $authuser, $storecfg, $vmid, $archive); + PVE::Storage::check_volume_access( + $rpcenv, + $authuser, + $storecfg, + $vmid, + $archive, + 'backup', + ); $archive = $parse_restore_archive->($storecfg, $archive); } -- 2.30.2