From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 963AA8D96 for ; Wed, 30 Mar 2022 12:25:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E6156DE3 for ; Wed, 30 Mar 2022 12:24:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 210E56DB1 for ; Wed, 30 Mar 2022 12:24:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ED87242003 for ; Wed, 30 Mar 2022 12:24:42 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 30 Mar 2022 12:24:26 +0200 Message-Id: <20220330102437.46955-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.115 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH-SERIES v2 manager/storage/container/qemu-server] improve check_volume_access X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 10:25:14 -0000 The first few patches are to allow access for users with Datastore.Allocate privilege, without automatically giving them permission to extract a backup config. Patch storage 3/6 is in preparation for the import-from API, allowing users with VM.Config.Disk (and Datastore.Audit) to list images of their VMs. The rest of the series introduces a content type parameter to check_volume_access() for future-proofing. Patch storage 2/6 technically breaks older manager, allowing all users with Datastore.Allocate to extract backup configs, but I'm not sure that's worth bothering about. Dependency bumps for storage are needed for the content parameter to actually have an effect. Changes from v1: * Always allow with Datastore.Allocate privilege. * Also check for Datastore.Audit when listing guest images/rootdir rather than just VM.Config.Disk. manager: Fabian Ebner (3): api: vzdump: extract config: check for VM.Backup privilege pveam: remove: add content type check api: vzdump: extract config: add content type check PVE/API2/VZDump.pm | 14 +++++++++++++- PVE/CLI/pveam.pm | 2 +- 2 files changed, 14 insertions(+), 2 deletions(-) storage: Fabian Ebner (6): pvesm: extract config: check for VM.Backup privilege check volume access: always allow with Datastore.Allocate privilege check volume access: allow for images/rootdir if user has VM.Config.Disk check volume accesss: add content type parameter pvesm: extract config: add content type check api: file restore: use check_volume_access to restrict content type PVE/API2/Storage/FileRestore.pm | 12 ++++-------- PVE/CLI/pvesm.pm | 14 +++++++++++++- PVE/Storage.pm | 15 ++++++++++++--- 3 files changed, 29 insertions(+), 12 deletions(-) container: Fabian Ebner (1): api: create/modify: add content type checks src/PVE/API2/LXC.pm | 10 +++++++++- src/PVE/LXC.pm | 9 ++++++++- 2 files changed, 17 insertions(+), 2 deletions(-) qemu-server: Fabian Ebner (1): api: create/modify: add content type checks PVE/API2/Qemu.pm | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) -- 2.30.2