From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 09FF26E086 for ; Mon, 28 Mar 2022 15:54:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9AC5264ED for ; Mon, 28 Mar 2022 15:53:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 61533264E4 for ; Mon, 28 Mar 2022 15:53:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 37E9144DD1 for ; Mon, 28 Mar 2022 15:53:47 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 28 Mar 2022 15:53:45 +0200 Message-Id: <20220328135345.1055583-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.147 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit] form: combo grid: fix selection after filtering X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 13:54:18 -0000 firing 'refresh' in 'clearLocalFilter' was wrong, since that triggers too often, for example when selecting an entry (since the field lost focus). This lead to the picker refreshing and not registering the click and thus not selecting the desired entry. Instead refresh the view when we really need it: when the picker is shown. The filter is already gone, but the picker grid does not know this yet, so we fire the event then. Fixes: 7e47328 ("Combogrid: clear filter on blur") Signed-off-by: Dominik Csapak --- src/form/ComboGrid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js index 3ee0238..4cb79d0 100644 --- a/src/form/ComboGrid.js +++ b/src/form/ComboGrid.js @@ -300,6 +300,7 @@ Ext.define('Proxmox.form.ComboGrid', { // // we save the minheight to reset it after the load picker.on('show', function() { + me.store.fireEvent('refresh'); if (me.enableLoadMask) { me.savedMinHeight = picker.getMinHeight(); picker.setMinHeight(100); @@ -324,7 +325,6 @@ Ext.define('Proxmox.form.ComboGrid', { me.store.removeFilter(me.queryFilter, true); me.queryFilter = null; me.changingFilters = false; - me.store.fireEvent('refresh'); } }, -- 2.30.2