From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 99DAD6DE6D for ; Mon, 28 Mar 2022 13:10:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8DDAD24F5C for ; Mon, 28 Mar 2022 13:10:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1407B24F49 for ; Mon, 28 Mar 2022 13:10:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D7135439C0 for ; Mon, 28 Mar 2022 13:10:42 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 28 Mar 2022 13:10:40 +0200 Message-Id: <20220328111041.1732567-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 1/2] api: osd: return block devices instead of dm node X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Mar 2022 11:10:43 -0000 Returning the block devices is more useful than the device node. The device node usually points to the DM device for bluestore OSDs: /dev/dm-x In almost all situations one will be interested in the physical device underneath, /dev/sdX or /dev/nvmeXnY. In the rare case that someone isn't, then one can get a lot of more information by running `ceph osd metadata `. Signed-off-by: Aaron Lauterer --- PVE/API2/Ceph/OSD.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm index 93433b3a..c3d1384e 100644 --- a/PVE/API2/Ceph/OSD.pm +++ b/PVE/API2/Ceph/OSD.pm @@ -143,9 +143,9 @@ __PACKAGE__->register_method ({ if ($e->{type} eq 'osd' && $osdmd) { if ($osdmd->{bluefs}) { $new->{osdtype} = 'bluestore'; - $new->{blfsdev} = $osdmd->{bluestore_bdev_dev_node}; - $new->{dbdev} = $osdmd->{bluefs_db_dev_node}; - $new->{waldev} = $osdmd->{bluefs_wal_dev_node}; + $new->{blfsdev} = $osdmd->{bluestore_bdev_devices}; + $new->{dbdev} = $osdmd->{bluefs_db_devices}; + $new->{waldev} = $osdmd->{bluefs_wal_devices}; } else { $new->{osdtype} = 'filestore'; } -- 2.30.2