From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B63A769CEA for ; Fri, 25 Mar 2022 11:55:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F29B9D2 for ; Fri, 25 Mar 2022 11:55:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EAAEF892 for ; Fri, 25 Mar 2022 11:55:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 65F8146FC1 for ; Fri, 25 Mar 2022 11:55:13 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 25 Mar 2022 11:55:03 +0100 Message-Id: <20220325105510.3262101-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 librados2-perl storage manager 0/7] Add Ceph safety checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Mar 2022 10:55:51 -0000 The main motivation behind this series is to leverage several safety checks that Ceph has to make sure it is ok to stop or destroy a service. For this to work, the librados2-perl needs to be adapted because if it is unsafe to perform one of the actions, the Ceph API will return an error with an explanation in the status message. The approach chosen is to simplify the bindings and handle errors on the Perl side. the RADOS.pm::mon_command now always returns a hash ref containing * return code * status message * data This makes it necessary to adapt packages that depend on librados2-perl to handle the changed return values: storage and manager. Therefore we need to coordinate breaking dependencies and releases of these packages! A new cmd-safety endpoint is added which is called from the GUI wherever possible to show a warning. changes: * simplify librados2-perl changes and always return hash ref instead of wantarray * one central cmd-safety API endpoint instead of multiple ones per service type librados2-perl: Aaron Lauterer (2): mon_command: refactor to pass all data to perl mon_command: optionally ignore errors PVE/RADOS.pm | 24 +++++++++++++++++++----- RADOS.xs | 18 ++++++------------ 2 files changed, 25 insertions(+), 17 deletions(-) storage:Aaron Lauterer (1): rbd: adapt to changed rados mon_command return values PVE/Storage/RBDPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) manager: Aaron Lauterer (4): ceph: adapt to changed rados mon_command return values api: ceph: add cmd-safety endpoint ui: osd: warn if removal could be problematic ui: osd: mon: mds: warn if stop/destroy actions are problematic PVE/API2/Ceph.pm | 102 +++++++++++++++++++++- PVE/API2/Ceph/MGR.pm | 2 +- PVE/API2/Ceph/MON.pm | 19 +++-- PVE/API2/Ceph/OSD.pm | 14 ++-- PVE/API2/Ceph/Pools.pm | 18 ++-- PVE/API2/Cluster/Ceph.pm | 6 +- PVE/CLI/pveceph.pm | 4 +- PVE/Ceph/Services.pm | 10 +-- PVE/Ceph/Tools.pm | 16 ++-- www/manager6/ceph/OSD.js | 140 ++++++++++++++++++++++++++----- www/manager6/ceph/ServiceList.js | 104 ++++++++++++++++++++--- 11 files changed, 360 insertions(+), 75 deletions(-) -- 2.30.2