From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9EFCF6B1CA for ; Fri, 18 Mar 2022 11:00:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E2C01BF25 for ; Fri, 18 Mar 2022 11:00:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1F9411BF1B for ; Fri, 18 Mar 2022 11:00:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D945646EC1 for ; Fri, 18 Mar 2022 11:00:11 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 18 Mar 2022 11:00:11 +0100 Message-Id: <20220318100011.886719-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.151 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit] Utils: clear cookies with secure flag set X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 10:00:48 -0000 otherwise firefox complains with a deprecation warning that the secureflag is not set but SameSite to 'None'. Since we cannot know how firefox will behave once that behaviour is no longer supported, add the secure flag now. we have to use the 'set' api of ExtJs to do that reliably Signed-off-by: Dominik Csapak --- src/Utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Utils.js b/src/Utils.js index 6781e44..52cc626 100644 --- a/src/Utils.js +++ b/src/Utils.js @@ -306,7 +306,7 @@ utilities: { if (Proxmox.LoggedOut) { return; } - Ext.util.Cookies.clear(Proxmox.Setup.auth_cookie_name); + Ext.util.Cookies.set(Proxmox.Setup.auth_cookie_name, "", new Date(0), null, null, true); window.localStorage.removeItem("ProxmoxUser"); }, -- 2.30.2