From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 49F106ADB9 for ; Thu, 17 Mar 2022 12:31:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 47C212C00 for ; Thu, 17 Mar 2022 12:31:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7F73A2BB8 for ; Thu, 17 Mar 2022 12:31:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 482C146EEA for ; Thu, 17 Mar 2022 12:31:12 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 17 Mar 2022 12:30:59 +0100 Message-Id: <20220317113107.60466-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220317113107.60466-1-f.ebner@proxmox.com> References: <20220317113107.60466-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.121 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH v13 qemu-server 1/8] clone disk: assert that drive name is the same for drive-mirror on single VM X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 11:31:14 -0000 because when the VM ID of target and source are the same, qemu_drive_mirror_monitor() switches the QEMU device node over to the new backing image. The planned import-from functionality makes it possible to run into this, although for an a bit unusual use case. Signed-off-by: Fabian Ebner --- New in v13. PVE/QemuServer.pm | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 6a9f6b31..dd6f48f3 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7585,11 +7585,17 @@ sub clone_disk { my ($newvmid, $dst_drivename, $efisize) = $dest->@{qw(vmid drivename efisize)}; my ($storage, $format) = $dest->@{qw(storage format)}; + my $use_drive_mirror = $full && $running && $src_drivename && !$snapname; + if ($src_drivename && $dst_drivename && $src_drivename ne $dst_drivename) { die "cloning from/to EFI disk requires EFI disk\n" if $src_drivename eq 'efidisk0' || $dst_drivename eq 'efidisk0'; die "cloning from/to TPM state requires TPM state\n" if $src_drivename eq 'tpmstate0' || $dst_drivename eq 'tpmstate0'; + + # This would lead to two device nodes in QEMU pointing to the same backing image! + die "cannot change drive name when cloning disk from/to the same VM\n" + if $use_drive_mirror && $vmid == $newvmid; } my $newvolid; @@ -7644,7 +7650,12 @@ sub clone_disk { } my $sparseinit = PVE::Storage::volume_has_feature($storecfg, 'sparseinit', $newvolid); - if (!$running || !$src_drivename || $snapname) { + if ($use_drive_mirror) { + die "cannot move TPM state while VM is running\n" if $src_drivename eq 'tpmstate0'; + + qemu_drive_mirror($vmid, $src_drivename, $newvolid, $newvmid, $sparseinit, $jobs, + $completion, $qga, $bwlimit); + } else { # TODO: handle bwlimits if ($dst_drivename eq 'efidisk0') { # the relevant data on the efidisk may be smaller than the source @@ -7661,11 +7672,6 @@ sub clone_disk { } else { qemu_img_convert($drive->{file}, $newvolid, $size, $snapname, $sparseinit); } - } else { - die "cannot move TPM state while VM is running\n" if $src_drivename eq 'tpmstate0'; - - qemu_drive_mirror($vmid, $src_drivename, $newvolid, $newvmid, $sparseinit, $jobs, - $completion, $qga, $bwlimit); } } -- 2.30.2