From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 890A16AB0D for ; Thu, 17 Mar 2022 09:38:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 785AF2FFA5 for ; Thu, 17 Mar 2022 09:37:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E6D0F2FF93 for ; Thu, 17 Mar 2022 09:37:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BDDF9428AA for ; Thu, 17 Mar 2022 09:37:51 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 17 Mar 2022 09:37:47 +0100 Message-Id: <20220317083748.16718-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.121 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 1/2] ui: disk storage selector: never send format when hideFormat is true X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2022 08:38:22 -0000 The backend will pick an appropriate format when nothing is specified. The comment made it sound like 'raw' would be sent, but that didn't actually happen on file-based storages, and now no format is sent, so adapt the comment too. Signed-off-by: Fabian Ebner --- www/manager6/form/DiskStorageSelector.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/form/DiskStorageSelector.js b/www/manager6/form/DiskStorageSelector.js index ac6b064f..14a678b7 100644 --- a/www/manager6/form/DiskStorageSelector.js +++ b/www/manager6/form/DiskStorageSelector.js @@ -28,7 +28,7 @@ Ext.define('PVE.form.DiskStorageSelector', { // hides the size field (e.g, for the efi disk dialog) hideSize: false, - // hides the format field (e.g. for TPM state), always assumes 'raw' + // hides the format field (e.g. for TPM state) hideFormat: false, // sets the initial size value @@ -66,7 +66,7 @@ Ext.define('PVE.form.DiskStorageSelector', { var select = !!rec.data.select_existing && !me.hideSelection; - formatsel.setDisabled(!selectformat); + formatsel.setDisabled(!selectformat || me.hideFormat); formatsel.setValue(selectformat ? 'qcow2' : 'raw'); hdfilesel.setDisabled(!select); -- 2.30.2