From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C21FA6A645 for ; Wed, 16 Mar 2022 12:34:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AE7DD27068 for ; Wed, 16 Mar 2022 12:34:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 42C642705F for ; Wed, 16 Mar 2022 12:34:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 12DBD4277D for ; Wed, 16 Mar 2022 12:34:24 +0100 (CET) From: Matthias Heiserer To: pve-devel@lists.proxmox.com Date: Wed, 16 Mar 2022 12:34:18 +0100 Message-Id: <20220316113418.748393-1-m.heiserer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit V2] ComboGrid: fix sorting when filtering X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2022 11:34:54 -0000 When clicking on a column to sort it, the filter doesn't reset. Previously, it forgot the filter until the value was changed. Signed-off-by: Matthias Heiserer --- Changes from v1: Introduce a config property to (en|dis)disable clearing the filter src/form/ComboGrid.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js index 33c1d75..fa1078d 100644 --- a/src/form/ComboGrid.js +++ b/src/form/ComboGrid.js @@ -12,6 +12,9 @@ Ext.define('Proxmox.form.ComboGrid', { // this value is used as default value after load() preferredValue: undefined, + clearFilterOnBlur: false, + clearFilterOnExit: true, + // hack: allow to select empty value // seems extjs does not allow that when 'editable == false' @@ -470,4 +473,12 @@ Ext.define('Proxmox.form.ComboGrid', { } }); }, + + listeners: { + collapse: function() { + if (this.clearFilterOnExit) { + this.clearLocalFilter(); + } + }, + }, }); -- 2.30.2