From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CE07E69B7D for ; Mon, 14 Mar 2022 10:35:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C3498E4D for ; Mon, 14 Mar 2022 10:35:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7576DE28 for ; Mon, 14 Mar 2022 10:35:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4D509457DA for ; Mon, 14 Mar 2022 10:35:11 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 14 Mar 2022 10:35:03 +0100 Message-Id: <20220314093509.349554-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.018 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v4 manager 0/6] ui: lxc/qemu: add reassign for disks and volumes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2022 09:35:42 -0000 This series adds the UI to reassign a disk / volume from one guest to another. To avoid button clutter, the Move, Reassing and Resize buttons are moved into a new submenu called "Disk/Volume Action". Patch 3 to 6 are optional. Patch 3 changes the labels for Move, Reassign and Resize to remove Volume & Disk as we already have this in the context of the submenu. Patch 4 only changes a double negated option. Patch 5 happend in the process of working on an interface for the reassign functionality. Since the work of modernizing this componend is done, why not use it Patch 6 changes how we store the max number of MPs possible because I ran into the issue, that I cannot easily match against the object key if it is 'mps' instead of 'mp'. v4: * add PVE.Util.nextFreeMP helper * filter templates in the reassign target guest list * code cleanup on multiple locations * fix padding v3: * change to Edit window, removing quite some boilerplate code * create new submenu for disk/volume actions * incorporate smaller style nits * simplify other labels as well, removing 'Volume' and 'Disk' as the context gives that away already v2: incorporated feedback I got off list, mainly * using more modern approaches * more arrow functions * reducing use of predefined cbind values and using inline functions when possible Aaron Lauterer (6): ui: utils: add nextFreeMP ui: lxc/qemu: add disk reassign and action submenu ui: lxc/qemu: disk/volume action simplify menu items ui: BusTypeSelector: change noVirtIO to withVirtIO ui: hdmove: modernize/refactor ui: util: refactor mps to mp www/manager6/Makefile | 1 + www/manager6/Utils.js | 19 +- www/manager6/form/BusTypeSelector.js | 4 +- www/manager6/form/ControllerSelector.js | 4 +- www/manager6/lxc/MPEdit.js | 2 +- www/manager6/lxc/MultiMPEdit.js | 4 +- www/manager6/lxc/Resources.js | 66 ++++-- www/manager6/qemu/CDEdit.js | 2 +- www/manager6/qemu/CIDriveEdit.js | 2 +- www/manager6/qemu/HDMove.js | 185 +++++++--------- www/manager6/qemu/HDReassign.js | 272 ++++++++++++++++++++++++ www/manager6/qemu/HardwareView.js | 69 ++++-- 12 files changed, 490 insertions(+), 140 deletions(-) create mode 100644 www/manager6/qemu/HDReassign.js -- 2.30.2