From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5F27A69159 for ; Fri, 11 Mar 2022 12:25:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BD2F723678 for ; Fri, 11 Mar 2022 12:25:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1F81C235E4 for ; Fri, 11 Mar 2022 12:25:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ECF4C42135 for ; Fri, 11 Mar 2022 12:25:19 +0100 (CET) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Fri, 11 Mar 2022 12:25:04 +0100 Message-Id: <20220311112504.595964-13-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220311112504.595964-1-o.bektas@proxmox.com> References: <20220311112504.595964-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.597 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 access-control 12/12] api: acl: only allow granting SU privilege if user already has it X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 11:25:54 -0000 Signed-off-by: Oguz Bektas --- v1->v2: * added new after discussion with fabian about security implications of allowing SU privilege to be granted by users with Permissions.Modify src/PVE/API2/ACL.pm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/PVE/API2/ACL.pm b/src/PVE/API2/ACL.pm index 857c672..d415334 100644 --- a/src/PVE/API2/ACL.pm +++ b/src/PVE/API2/ACL.pm @@ -134,6 +134,10 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; + my $rpcenv = PVE::RPCEnvironment::get(); + my $authuser = $rpcenv->get_user(); + my $is_superuser = $rpcenv->check($authuser, $param->{path}, ['SuperUser'], 1); + if (!($param->{users} || $param->{groups} || $param->{tokens})) { raise_param_exc({ map { $_ => "either 'users', 'groups' or 'tokens' is required." } qw(users groups tokens) }); } @@ -160,6 +164,11 @@ __PACKAGE__->register_method ({ die "role '$role' does not exist\n" if !$cfg->{roles}->{$role}; + my $role_privs = $cfg->{roles}->{$role}; + my $role_contains_superuser = grep { $_ eq 'SuperUser' } keys %$role_privs; + die "only superusers can grant this role!\n" + if !$is_superuser && $role_contains_superuser; + foreach my $group (split_list($param->{groups})) { die "group '$group' does not exist\n" -- 2.30.2