From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 505A068E0B for ; Thu, 10 Mar 2022 15:32:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 473601BF1F for ; Thu, 10 Mar 2022 15:31:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AD60F1BF16 for ; Thu, 10 Mar 2022 15:31:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 82DA046401 for ; Thu, 10 Mar 2022 15:31:38 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 10 Mar 2022 15:31:37 +0100 Message-Id: <20220310143137.1384472-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.153 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [used.total] Subject: [pve-devel] [PATCH widget-toolkit] StatusView: fix usage calculation for fields without valid values X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 14:32:09 -0000 Sometimes, total can be zero (e.g. for swap when it's not used), which leads to the usage being NaN. This led to the progressbar not being updated for InfoWidgets, leaving a spurious '0%' as text. Signed-off-by: Dominik Csapak --- src/panel/StatusView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panel/StatusView.js b/src/panel/StatusView.js index 4a60dae..e2e81e2 100644 --- a/src/panel/StatusView.js +++ b/src/panel/StatusView.js @@ -47,7 +47,7 @@ Ext.define('Proxmox.panel.StatusView', { */ if (used.used !== undefined && used.total !== undefined) { - return used.used/used.total; + return used.total > 0 ? used.used/used.total : 0; } } -- 2.30.2