From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 278096872C for ; Wed, 9 Mar 2022 15:09:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1AD06824 for ; Wed, 9 Mar 2022 15:09:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A257081A for ; Wed, 9 Mar 2022 15:09:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 65FFA45899 for ; Wed, 9 Mar 2022 15:09:15 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 9 Mar 2022 15:09:14 +0100 Message-Id: <20220309140914.994552-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.153 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager] ui: Utils: remove unnecessary render_kvm_vga_driver X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 14:09:16 -0000 the 'value' here is already the rendered text, passing it through render again does not make sense Signed-off-by: Dominik Csapak --- www/manager6/Utils.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index aafe359a..d6aeaf31 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -653,9 +653,9 @@ Ext.define('PVE.Utils', { }, kvm_vga_driver_array: function() { - var data = [['__default__', PVE.Utils.render_kvm_vga_driver('')]]; + var data = [['__default__', Proxmox.Utils.defaultText]]; Ext.Object.each(PVE.Utils.kvm_vga_drivers, function(key, value) { - data.push([key, PVE.Utils.render_kvm_vga_driver(value)]); + data.push([key, value]); }); return data; -- 2.30.2