From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 572FE65E50 for ; Wed, 9 Mar 2022 11:09:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4DCE21B7EE for ; Wed, 9 Mar 2022 11:09:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BB7C01B7D7 for ; Wed, 9 Mar 2022 11:09:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8EFB346408 for ; Wed, 9 Mar 2022 11:09:24 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 9 Mar 2022 11:09:06 +0100 Message-Id: <20220309100919.31512-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220309100919.31512-1-f.ebner@proxmox.com> References: <20220309100919.31512-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.126 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v12 qemu-server 04/16] clone disk: remove check for min QEMU version 2.7 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 10:09:25 -0000 Upgrading a cluster node entails re-starting or migrating VMs and even PVE 6.0 already had QEMU 4.0. Signed-off-by: Fabian Ebner --- PVE/QemuServer.pm | 7 ------- 1 file changed, 7 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index b7e6a8e..c0fca49 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7642,15 +7642,8 @@ sub clone_disk { qemu_img_convert($drive->{file}, $newvolid, $size, $snapname, $sparseinit); } } else { - die "cannot move TPM state while VM is running\n" if $drivename eq 'tpmstate0'; - my $kvmver = get_running_qemu_version ($vmid); - if (!min_version($kvmver, 2, 7)) { - die "drive-mirror with iothread requires qemu version 2.7 or higher\n" - if $drive->{iothread}; - } - qemu_drive_mirror($vmid, $drivename, $newvolid, $newvmid, $sparseinit, $jobs, $completion, $qga, $bwlimit); } -- 2.30.2