From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7C17D65E6B for ; Wed, 9 Mar 2022 11:09:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 553E81B969 for ; Wed, 9 Mar 2022 11:09:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 51BD31B7EF for ; Wed, 9 Mar 2022 11:09:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 27C664640E for ; Wed, 9 Mar 2022 11:09:25 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 9 Mar 2022 11:09:04 +0100 Message-Id: <20220309100919.31512-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220309100919.31512-1-f.ebner@proxmox.com> References: <20220309100919.31512-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.124 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v12 qemu-server 02/16] api: create disks: always activate/update size when attaching existing volume X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 10:09:32 -0000 For creation, activation and size update never triggered, because the passed in $conf is essentially the same as the creation $settings, so the disk was always detected to be the same as the "existing" one. But actually, all disks are new, so it makes sense to do it. For update, activation and size update nearly always triggered, because only the pending changes are passed in as $conf. The case where it didn't trigger is when the same pending change was made twice (there are cases where hotplug isn't done, but makes it even more unlikely). Signed-off-by: Fabian Ebner --- PVE/API2/Qemu.pm | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 9be1caf..02b26d2 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -213,26 +213,13 @@ my $create_disks = sub { delete $disk->{format}; # no longer needed $res->{$ds} = PVE::QemuServer::print_drive($disk); } else { - PVE::Storage::check_volume_access($rpcenv, $authuser, $storecfg, $vmid, $volid); - my $volid_is_new = 1; - - if ($conf->{$ds}) { - my $olddrive = PVE::QemuServer::parse_drive($ds, $conf->{$ds}); - $volid_is_new = undef if $olddrive->{file} && $olddrive->{file} eq $volid; - } - - if ($volid_is_new) { + PVE::Storage::activate_volumes($storecfg, [ $volid ]) if $storeid; - PVE::Storage::activate_volumes($storecfg, [ $volid ]) if $storeid; - - my $size = PVE::Storage::volume_size_info($storecfg, $volid); - - die "volume $volid does not exist\n" if !$size; - - $disk->{size} = $size; - } + my $size = PVE::Storage::volume_size_info($storecfg, $volid); + die "volume $volid does not exist\n" if !$size; + $disk->{size} = $size; $res->{$ds} = PVE::QemuServer::print_drive($disk); } -- 2.30.2