From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 839EA6561C for ; Mon, 7 Mar 2022 13:17:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2FC6E272B9 for ; Mon, 7 Mar 2022 13:17:54 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B276727172 for ; Mon, 7 Mar 2022 13:17:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7545346E6A for ; Mon, 7 Mar 2022 13:17:48 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 7 Mar 2022 13:17:28 +0100 Message-Id: <20220307121743.60206-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.126 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH-SERIES v11 qemu-server/manager] API for disk import and OVF X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2022 12:17:54 -0000 Extend qm importdisk/importovf functionality to the API. Changes from v10: * Add fix for device unplug issue (patch #1). * Add fixes related to calling create_disks() (patches #2 #3). * Refactor clone_disk() in preparation to re-use it for import (patches #4 #5 #6). * Add patch to print the newly allocated drive (patch #14). * Switch to using clone_disk for PVE-managed volumes and check for VM.Clone in the permission check if there is an owner ID. * Require :0 syntax when using import-from. Allowing other values than 0 for the size would be confusing, because with import-from that size is never used (the size of the source image is). * Avoid making all foreach_volume iterators parse with the extended schema. Instead, provide a custom iterator for the places where it's actually required. Still missing GUI integration for import from ovf, but that will be it's own series. Previous discussion: https://lists.proxmox.com/pipermail/pve-devel/2022-January/051379.html qemu-server: Dominic Jäger (1): api: support VM disk import Fabian Ebner (13): device unplug: verify that unplugging scsi disk completed api: create disks: always activate/update size when attaching existing volume api: update: pass correct config when creating disks clone disk: remove check for min QEMU version 2.7 clone disk: group source and target parameters clone disk: allow cloning from an unused or unreferenced disk schema: add pve-volume-id-or-absolute-path parse ovf: untaint path when calling file_size_info api: add endpoint for parsing .ovf files image convert: allow block device as source api: factor out check/cleanup for drive params schema: drive: use separate schema when disk allocation is possible api: update vm: print drive string for newly allocated/imported drives PVE/API2/Qemu.pm | 365 ++++++++++++++++++++++++++--------- PVE/API2/Qemu/Makefile | 2 +- PVE/API2/Qemu/OVF.pm | 55 ++++++ PVE/QemuServer.pm | 99 +++++++--- PVE/QemuServer/Drive.pm | 94 ++++++--- PVE/QemuServer/ImportDisk.pm | 2 +- PVE/QemuServer/OVF.pm | 9 +- 7 files changed, 487 insertions(+), 139 deletions(-) create mode 100644 PVE/API2/Qemu/OVF.pm manager: Fabian Ebner (1): api: nodes: add readovf endpoint PVE/API2/Nodes.pm | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.30.2