From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 42A0A6547D for ; Mon, 7 Mar 2022 11:07:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 39F9C25A40 for ; Mon, 7 Mar 2022 11:07:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3BCF225A25 for ; Mon, 7 Mar 2022 11:07:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0726F463D0 for ; Mon, 7 Mar 2022 11:07:24 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 7 Mar 2022 11:07:18 +0100 Message-Id: <20220307100722.257128-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 manager 0/4] ui: lxc/qemu: add reassign for disks and volumes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2022 10:07:25 -0000 This series adds the UI to reassign a disk / volume from one guest to another. To avoid button clutter, the Move, Reassing and Resize buttons are moved into a new submenu called "Disk/Volume Action". Patch 2 to 4 are optional. Patch 2 changes the labels for Move, Reassign and Resize to remove Volume & Disk as we already have this in the context of the submenu. Patch 3 only changes a double negated option and patch 4 happend in the process of working on an interface for the reassign functionality. Since the work of modernizing this componend is done, why not use it v3: * change to Edit window, removing quite some boilerplate code * create new submenu for disk/volume actions * incorporate smaller style nits * simplify other labels as well, removing 'Volume' and 'Disk' as the context gives that away already v2: incorporated feedback I got off list, mainly * using more modern approaches * more arrow functions * reducing use of predefined cbind values and using inline functions when possible Aaron Lauterer (4): ui: lxc/qemu: add disk reassign and action submenu ui: lxc/qemu: disk/volume action simplify menu items ui: BusTypeSelector: change noVirtIO to withVirtIO ui: hdmove: modernize/refactor www/manager6/Makefile | 1 + www/manager6/form/BusTypeSelector.js | 4 +- www/manager6/form/ControllerSelector.js | 4 +- www/manager6/lxc/Resources.js | 66 ++++-- www/manager6/qemu/CDEdit.js | 2 +- www/manager6/qemu/CIDriveEdit.js | 2 +- www/manager6/qemu/HDMove.js | 192 ++++++++--------- www/manager6/qemu/HDReassign.js | 274 ++++++++++++++++++++++++ www/manager6/qemu/HardwareView.js | 65 +++++- 9 files changed, 476 insertions(+), 134 deletions(-) create mode 100644 www/manager6/qemu/HDReassign.js -- 2.30.2