From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C198D64408 for ; Wed, 2 Mar 2022 14:21:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B65E529D90 for ; Wed, 2 Mar 2022 14:21:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8BFA929D84 for ; Wed, 2 Mar 2022 14:21:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 35B7146E41 for ; Wed, 2 Mar 2022 14:21:11 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 2 Mar 2022 14:21:07 +0100 Message-Id: <20220302132107.109741-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.129 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH qemu-server] qmp client: increase timeout for thaw X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 13:21:12 -0000 Using a loop of freeze, sleep 5, thaw, sleep 5, an idling Windows 11 VM with 4 cores and 8GiB RAM once took 54 seconds for thawing. It took less than a second about 90% of the time and maximum of a few seconds for the majortiy of other cases, but there can be outliers where 10 seconds is not enough. And there can be hookscripts executed upon thaw, which might also not complete instantly. Signed-off-by: Fabian Ebner --- PVE/QMPClient.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm index ea4dc0b..8af28e8 100644 --- a/PVE/QMPClient.pm +++ b/PVE/QMPClient.pm @@ -113,9 +113,10 @@ sub cmd { # locked state with high probability, so use an generous timeout $timeout = 60*60; # 1 hour } elsif ($cmd->{execute} eq 'guest-fsfreeze-thaw') { - # thaw has no possible long blocking actions, either it returns - # instantly or never (dead locked) - $timeout = 10; + # While it should return instantly or never (dead locked) for Linux guests, + # the variance for Windows guests can be big. And there might be hook scripts + # that are executed upon thaw, so use 3 minutes to be on the safe side. + $timeout = 3 * 60; } elsif ($cmd->{execute} eq 'savevm-start' || $cmd->{execute} eq 'savevm-end' || $cmd->{execute} eq 'query-backup' || -- 2.30.2