From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B9F6B64343 for ; Wed, 2 Mar 2022 11:13:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A7A152802A for ; Wed, 2 Mar 2022 11:12:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7DA0B2801E for ; Wed, 2 Mar 2022 11:12:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4C8AE41DC5 for ; Wed, 2 Mar 2022 11:12:50 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 2 Mar 2022 11:12:49 +0100 Message-Id: <20220302101249.1137742-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager] ui: osd: send in/out cmd to currently used node X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 10:13:21 -0000 The in & out commands for OSDs are not node specific and can be run on any node in the Ceph cluster. By sending them to the node currently used to access the UI they can still be sent even if the node on which the OSDs are located is down. This helps in a disaster scenario where a node is down. By default Ceph will mark a downed OSD as out after 10 minutes. This could be too long in some situations. Running the CLI command to mark the OSD as out earlier on one of the remaining nodes does work, but if the admin is not used doing it this way, this adds stress, in a potentially already stressful situation. Signed-off-by: Aaron Lauterer --- www/manager6/ceph/OSD.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index e126f8d0..78f226ff 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager6/ceph/OSD.js @@ -391,8 +391,13 @@ Ext.define('PVE.node.CephOsdTree', { let osdid = vm.get('osdid'); let doRequest = function() { + let targetnode = vm.get('osdhost'); + // cmds not node specific and need to work if the OSD node is down + if (['in', 'out'].includes(cmd)) { + targetnode = vm.get('nodename'); + } Proxmox.Utils.API2Request({ - url: "/nodes/" + vm.get('osdhost') + "/ceph/osd/" + osdid + '/' + cmd, + url: `/nodes/${targetnode}/ceph/osd/${osdid}/${cmd}`, waitMsgTarget: me.getView(), method: 'POST', params: params, -- 2.30.2