From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C5ED863E21 for ; Mon, 28 Feb 2022 15:47:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B48061808C for ; Mon, 28 Feb 2022 15:46:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 29E7218081 for ; Mon, 28 Feb 2022 15:46:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EFA70462C4 for ; Mon, 28 Feb 2022 15:46:47 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 28 Feb 2022 15:46:46 +0100 Message-Id: <20220228144646.1517147-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.155 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH guest-common] GuestHelpers: fix snapshot indentation length X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 14:47:19 -0000 if a user has many snapshots, the length goes negative and produces wrong indentation, so clamp it at 0 reported by a user in the forum: https://forum.proxmox.com/threads/non-threaded-listsnaphost-view.105740/ Signed-off-by: Dominik Csapak --- for many snapshots this still looks weird, but has a consistent indentation. to do it completely right, we'd have to iterate twice and find the longest line first and use that as width for the first column. not sure if worth the effort. src/PVE/GuestHelpers.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/GuestHelpers.pm b/src/PVE/GuestHelpers.pm index 970c460..0c8ed66 100644 --- a/src/PVE/GuestHelpers.pm +++ b/src/PVE/GuestHelpers.pm @@ -157,6 +157,7 @@ sub print_snapshot_tree { } my $len = 30 - length($prefix); # for aligning the description + $len = 0 if $len < 0; printf("%s %-${len}s %-23s %s\n", $prefix, $root, $timestring, $description); if ($e->{children}) { -- 2.30.2