From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F1D9363427 for ; Thu, 24 Feb 2022 15:27:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE8511918C for ; Thu, 24 Feb 2022 15:27:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id CACC319168 for ; Thu, 24 Feb 2022 15:27:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5A09A41B37 for ; Thu, 24 Feb 2022 15:22:00 +0100 (CET) From: Stefan Sterz To: pve-devel@lists.proxmox.com Date: Thu, 24 Feb 2022 15:21:49 +0100 Message-Id: <20220224142151.3206908-2-s.sterz@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220224142151.3206908-1-s.sterz@proxmox.com> References: <20220224142151.3206908-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nodeconfig.pm] Subject: [pve-devel] [PATCH manager 2/4] parse node config: remove "\s*" from comment regex X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2022 14:27:37 -0000 To be consistent with PBS's implementation of multi-line comments remove "\s*" here too. Since the regex isn't lazy .* matches everything \s* would anyway. (Note that new lines occurs after "$"). Signed-off-by: Stefan Sterz --- PVE/NodeConfig.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/NodeConfig.pm b/PVE/NodeConfig.pm index df44410f..4c2fc570 100644 --- a/PVE/NodeConfig.pm +++ b/PVE/NodeConfig.pm @@ -205,7 +205,7 @@ sub parse_node_config { my @lines = split(/\n/, $content); foreach my $line (@lines) { - if ($line =~ /^\#(.*)\s*$/ || $line =~ /^description:\s*(.*\S)\s*$/) { + if ($line =~ /^\#(.*)$/ || $line =~ /^description:\s*(.*\S)\s*$/) { $descr .= PVE::Tools::decode_text($1) . "\n"; next; } -- 2.30.2