From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2F4A962F63 for ; Wed, 23 Feb 2022 13:04:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 262742DF63 for ; Wed, 23 Feb 2022 13:04:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 18F2B2DF3E for ; Wed, 23 Feb 2022 13:04:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E91A04092B for ; Wed, 23 Feb 2022 13:04:02 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 23 Feb 2022 13:03:56 +0100 Message-Id: <20220223120359.45928-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.130 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH-SERIES v4 container/qemu-server] fix #3424: wait for active replication when deleting a snapshot X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2022 12:04:34 -0000 Avoid that an attempt to remove a snapshot that's actively used by replication leads to a partially (or not) removed snapshot and locked guest. I decided to make the checks at the call sides, because passing the log function and timeout to snapshot_delete felt awkward as they would only be used for obtaining the lock. Changes from v3: * Unconditionally take the lock, to not race with replication job creation and future-proofing. * Only log in the case with the long timeout if we can't obtain the lock quickly. * Make message more general, because it might be another snapshot removal operation holding the lock. container: Fabian Ebner (2): partially fix #3424: vzdump: cleanup: wait for active replication fix #3424: api: snapshot delete: wait for active replication src/PVE/API2/LXC/Snapshot.pm | 11 ++++++++++- src/PVE/VZDump/LXC.pm | 20 ++++++++++++++++++-- 2 files changed, 28 insertions(+), 3 deletions(-) qemu-server: Fabian Ebner (1): fix #3424: api: snapshot delete: wait for active replication PVE/API2/Qemu.pm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) -- 2.30.2