From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 800A2612B1 for ; Fri, 18 Feb 2022 12:38:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 76A7F29361 for ; Fri, 18 Feb 2022 12:38:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E9DAF29345 for ; Fri, 18 Feb 2022 12:38:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B6ACE46D07 for ; Fri, 18 Feb 2022 12:38:28 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 18 Feb 2022 12:38:22 +0100 Message-Id: <20220218113827.1415641-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220218113827.1415641-1-a.lauterer@proxmox.com> References: <20220218113827.1415641-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH librados2-perl 1/6] mon_command: free outs buffer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Feb 2022 11:38:29 -0000 Signed-off-by: Aaron Lauterer --- thanks @Dominik who realized that we did not free this buffer in all situations. RADOS.xs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/RADOS.xs b/RADOS.xs index 7eca024..1eb0b5a 100644 --- a/RADOS.xs +++ b/RADOS.xs @@ -145,6 +145,10 @@ CODE: RETVAL = newSVpv(outbuf, outbuflen); rados_buffer_free(outbuf); + + if (outs != NULL) { + rados_buffer_free(outs); + } } OUTPUT: RETVAL -- 2.30.2