From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EEC1662783 for ; Fri, 11 Feb 2022 16:16:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 51B022BCFD for ; Fri, 11 Feb 2022 16:16:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2219B2BCA9 for ; Fri, 11 Feb 2022 16:16:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id F089C46262 for ; Fri, 11 Feb 2022 16:16:03 +0100 (CET) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Fri, 11 Feb 2022 16:15:47 +0100 Message-Id: <20220211151547.181259-8-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220211151547.181259-1-s.ivanov@proxmox.com> References: <20220211151547.181259-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.240 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH proxmox-ve v3 3/3] apt-hook: add check preventing the removal of pinned kernels X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2022 15:16:07 -0000 the $file_read_firstline helper code is copied from PVE::Tools, since we do not want to depend on pve-common being in good shape when the apt hook is executed Co-authored-by: Fabian Grünbichler Signed-off-by: Stoiko Ivanov --- debian/apthook/pve-apt-hook | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/debian/apthook/pve-apt-hook b/debian/apthook/pve-apt-hook index 8fa58c5..47629bc 100755 --- a/debian/apthook/pve-apt-hook +++ b/debian/apthook/pve-apt-hook @@ -34,6 +34,17 @@ my $cleanup = sub { exit $rc; }; +my $file_read_firstline = sub { + my ($filename) = @_; + + my $fh = IO::File->new($filename, "r"); + return undef if !$fh; + my $res = <$fh>; + chomp $res if $res; + $fh->close; + return $res; +}; + chomp (my $ver = <$fh>); if ($ver ne "VERSION 2") { $log->("apt-pve-hook misconfigured, expecting hook protocol version 2\n"); @@ -84,6 +95,23 @@ while (my $line = <$fh>) { $cleanup->(0, 1); } } + if ($pkg =~ /^pve-kernel-/) { + if ($action eq '**REMOVE**') { + my $next_boot_ver = $file_read_firstline->("/etc/kernel/next-boot-pin"); + my $pinned_ver = $file_read_firstline->("/etc/kernel/proxmox-boot-pin"); + my $remove_pinned_ver = ($next_boot_ver && $pkg =~ /$next_boot_ver$/); + $remove_pinned_ver ||= ($pinned_ver && $pkg =~ /$pinned_ver$/); + if ($remove_pinned_ver) { + $log->("!! WARNING !!\n"); + $log->("You are attempting to remove the currently pinned kernel '${pkg}'!\n"); + $log->("\n"); + $log->("If you really do not need the version anymore unpin it by running\n"); + $log->("\tproxmox-boot-tool kernel unpin'\n"); + $log->("and repeat your apt invocation.\n"); + $cleanup->(1); + } + } + } } $cleanup->(0); -- 2.30.2