From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D11FF61186 for ; Tue, 8 Feb 2022 14:10:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C7A7C2EC6A for ; Tue, 8 Feb 2022 14:10:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DA9B52EC36 for ; Tue, 8 Feb 2022 14:10:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9C82446109 for ; Tue, 8 Feb 2022 14:10:16 +0100 (CET) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Tue, 8 Feb 2022 14:10:06 +0100 Message-Id: <20220208131011.752134-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.669 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [accesscontrol.pm, status.pm, rpcenvironment.pm, lxc.pm, qemu.pm, tfa.pm] Subject: [pve-devel] [PATCH v1 access-control++ 0/5] SuperUser privilege X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 13:10:50 -0000 "SuperUser" (henceforth referred as SU) privilege allows to give root-only permissions to API users, enabling them to perform privileged actions on behalf of root@pam. this privilege is enabled by default for "root@pam", and also mapped inside "SuperAdministrator" (referred as SA) changes from RFC (thanks for the review fabian g.!): * manager: allow SAs to see/edit certain things on GUI * qemu-server: also check the required non-root VM privileges along with the SU priv * pve-container: adapted error messages, changed variable name to "is_superuser" for better clarity (in comparison to prev. "is_root" which is a bit confusing) * access-control: TFA permissions adaptation for SAs access-control: Oguz Bektas (2): add "SuperAdministrator" role with the new "SuperUser" privilege tfa: allow superusers to edit root@pam tfa src/PVE/API2/TFA.pm | 7 +++++-- src/PVE/AccessControl.pm | 9 ++++++--- src/PVE/RPCEnvironment.pm | 2 +- 3 files changed, 12 insertions(+), 6 deletions(-) container: Oguz Bektas (1): fix #2582: api: add checks for 'SuperUser' privilege for root-only options src/PVE/API2/LXC.pm | 13 ++++++------- src/PVE/API2/LXC/Status.pm | 8 ++++++-- src/PVE/LXC.pm | 9 ++++++--- 3 files changed, 18 insertions(+), 12 deletions(-) manager: Oguz Bektas (1): change 'root@pam' checks with 'SuperUser' capability check www/manager6/Utils.js | 3 ++- www/manager6/dc/Config.js | 2 +- www/manager6/dc/UserView.js | 2 +- www/manager6/lxc/Options.js | 2 +- www/manager6/lxc/Resources.js | 2 +- www/manager6/node/Config.js | 2 +- www/manager6/window/Migrate.js | 4 ++-- 7 files changed, 9 insertions(+), 8 deletions(-) qemu-server: Oguz Bektas (1): add SuperUser privilege checks for root-only options PVE/API2/Qemu.pm | 119 +++++++++++++++++++++++++++++------------------ 1 file changed, 73 insertions(+), 46 deletions(-) -- 2.30.2