From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 31ED0611F1 for ; Fri, 4 Feb 2022 10:50:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2FE7F2FC34 for ; Fri, 4 Feb 2022 10:50:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 556982FC2B for ; Fri, 4 Feb 2022 10:50:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 261834062A for ; Fri, 4 Feb 2022 10:50:07 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 4 Feb 2022 10:50:06 +0100 Message-Id: <20220204095006.127477-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager] ui: osd: warn if removal could be problematic X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 09:50:09 -0000 If an OSD is removed during the wrong conditions, it could lead to blocked IO or worst case data loss. Check against global flags that limit the capabilities of Ceph to heal itself (norebalance, norecover, noout) and if there are degraded objects. Signed-off-by: Aaron Lauterer --- Those are the things to check for that came to mind. If someone thinks that we should definitely check for more, I am happy to send a v2. I am also open to suggestions on how to phrase the warnings better. I opted for separate hints to be able to show detailed hints so the users have an idea how to act on the warning and to keep the logic behind them simple. www/manager6/ceph/OSD.js | 41 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js index e126f8d0..7ab11b9e 100644 --- a/www/manager6/ceph/OSD.js +++ b/www/manager6/ceph/OSD.js @@ -178,6 +178,20 @@ Ext.define('PVE.CephRemoveOsd', { labelWidth: 130, fieldLabel: gettext('Cleanup Disks'), }, + { + xtype: 'displayfield', + name: 'osd-flag-hint', + userCls: 'pmx-hint', + value: gettext('Global flags that limit the self healing of Ceph are enabled.'), + hidden: true, + }, + { + xtype: 'displayfield', + name: 'degraded-objects-hint', + userCls: 'pmx-hint', + value: gettext('Objects are degraded. Consider waiting until the cluster is healthy.'), + hidden: true, + }, ], initComponent: function() { let me = this; @@ -193,6 +207,33 @@ Ext.define('PVE.CephRemoveOsd', { me.title = gettext('Destroy') + ': Ceph OSD osd.' + me.osdid.toString(); + Proxmox.Utils.API2Request({ + url: `/cluster/ceph/flags`, + method: 'GET', + failure: response => Ext.Msg.alert(gettext('Error'), response.htmlStatus), + success: function({ result: { data } }) { + let flags = Array.from( + data.filter(v => v.value), + v => v.name, + ).filter(v => ['norebalance', 'norecover', 'noout'].includes(v)); + + if (flags.length) { + me.down('field[name=osd-flag-hint]').setHidden(false); + } + }, + }); + + Proxmox.Utils.API2Request({ + url: `/cluster/ceph/status`, + method: 'GET', + failure: response => Ext.Msg.alert(gettext('Error'), response.htmlStatus), + success: function({ result: { data } }) { + if (Object.keys(data.pgmap).includes('degraded_objects')) { + me.down('field[name=degraded-objects-hint]').setHidden(false); + } + }, + }); + Ext.applyIf(me, { url: "/nodes/" + me.nodename + "/ceph/osd/" + me.osdid.toString(), }); -- 2.30.2