From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 832DE63D49 for ; Thu, 27 Jan 2022 15:02:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 71BD823804 for ; Thu, 27 Jan 2022 15:02:00 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D4AE7237EB for ; Thu, 27 Jan 2022 15:01:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AE95146CC7 for ; Thu, 27 Jan 2022 15:01:59 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 27 Jan 2022 15:01:55 +0100 Message-Id: <20220127140155.66141-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220127140155.66141-1-f.ebner@proxmox.com> References: <20220127140155.66141-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.133 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 4/4] clone disk: don't modify drive parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jan 2022 14:02:30 -0000 While existing callers are not using the parameter after the call, the modification is rather unexpected and could lead to bugs quickly. Also avoid setting an undef value in the hash, but use delete instead. Signed-off-by: Fabian Ebner --- PVE/QemuServer.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 4f531f2..8aa1946 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -7642,8 +7642,8 @@ sub clone_disk { no_data_clone: my ($size) = eval { PVE::Storage::volume_size_info($storecfg, $newvolid, 10) }; - my $disk = $drive; - $disk->{format} = undef; + my $disk = dclone($drive); + delete $disk->{format}; $disk->{file} = $newvolid; $disk->{size} = $size if defined($size); -- 2.30.2