From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <d.csapak@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8724563D08 for <pve-devel@lists.proxmox.com>; Thu, 27 Jan 2022 11:56:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 829BF215B5 for <pve-devel@lists.proxmox.com>; Thu, 27 Jan 2022 11:56:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 81D4A21578 for <pve-devel@lists.proxmox.com>; Thu, 27 Jan 2022 11:56:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 505E246CC7 for <pve-devel@lists.proxmox.com>; Thu, 27 Jan 2022 11:56:02 +0100 (CET) From: Dominik Csapak <d.csapak@proxmox.com> To: pve-devel@lists.proxmox.com Date: Thu, 27 Jan 2022 11:55:53 +0100 Message-Id: <20220127105601.2741602-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.160 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-backup/common/storage/wt] improve file-restore timeout behaviour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 27 Jan 2022 10:56:34 -0000 this series improves the behaviour of the file-restore when some mount operations take longer than the 30 second pveproxy timeout, and improves the startup speed of the restore vm we do this by moving the disk init into the background of the daemon startup, while the hyper server is starting, and by adding a timeout option to the file-restore binary. to be able to report the error back to the gui, we return a 'SERVICE_UNAVAILABLE' error in the timeout case, and the gui tries again (up to 10 times). backup patches 2,3 could be applied independently, as they even make sense withouth the rest pve-storage depends on a new pve-common&file-restore widget-toolkit makes only sense with the other patches, but is designed to not change behaviour with the old api alternatively i could drop the 'json-error' parameter and do it always, or when timeout it set. proxmox-backup: Dominik Csapak (5): restore-daemon: start disk initialization in parallel to the api restore-daemon: put blocking code into 'block_in_place' restore-daemon: avoid auto-mounting zpools file-restore: factor out 'list_files' file-restore: add 'timeout' and 'json-error' parameter proxmox-file-restore/src/main.rs | 196 ++++++++++++------ proxmox-restore-daemon/src/main.rs | 31 ++- .../src/proxmox_restore_daemon/api.rs | 12 +- .../src/proxmox_restore_daemon/disk.rs | 20 +- 4 files changed, 160 insertions(+), 99 deletions(-) pve-common: Dominik Csapak (1): PBSClient: add option for extra parameter to file_restore_list src/PVE/PBSClient.pm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) pve-storage: Dominik Csapak (1): api: FileRestore: use new timeout and json-error parameters for list PVE/API2/Storage/FileRestore.pm | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) proxmox-widget-toolkit: Dominik Csapak (1): window/FileBrowser: try reload again when getting a 503 error src/window/FileBrowser.js | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) -- 2.30.2