From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6C5A760E48 for ; Fri, 14 Jan 2022 11:52:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5E21F28AEF for ; Fri, 14 Jan 2022 11:51:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5AFAF28AE4 for ; Fri, 14 Jan 2022 11:51:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3282C46CBA; Fri, 14 Jan 2022 11:51:49 +0100 (CET) Date: Fri, 14 Jan 2022 11:51:47 +0100 From: Wolfgang Bumiller To: alexandre derumier Cc: Thomas Lamprecht , Proxmox VE development discussion Message-ID: <20220114105147.735ykiad3qva6rge@wobu-vie.proxmox.com> References: <20210914002606.1608165-1-aderumier@odiso.com> <4a34d44143f1c32f38988c478698c094badbc740.camel@odiso.com> <790dd453ab8b0fab53942c7dd4b536d5285a3c00.camel@odiso.com> <478a4600-48f4-3fe8-91ec-e2dbb27bd2c8@proxmox.com> <5e94541c69f65eb9859d6b9f036ed80acf8f113e.camel@odiso.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5e94541c69f65eb9859d6b9f036ed80acf8f113e.camel@odiso.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.399 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-common] network: disable unicast flooding on tap|veth|fwln ports X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2022 10:52:20 -0000 On Thu, Sep 16, 2021 at 11:48:15PM +0200, alexandre derumier wrote: > Le mercredi 15 septembre 2021 à 19:09 +0200, Thomas Lamprecht a écrit : > > On 15.09.21 17:33, alexandre derumier wrote: > > > I have looked at other hypervisors implementations (as it don't see > > > to > > > have problem with hetzner), > > > > > > > > > https://listman.redhat.com/archives/libvir-list/2014-December/msg00173.html > > > > > > > > > https://docs.vmware.com/en/VMware-NSX-T-Data-Center/3.1/administration/GUID-C5752084-A582-4AEA-BD5D-03FE5DBC746E.html > > > > > > > > > Both vmware && libvirt have a mode to manually manage fdb entries > > > in > > > bridge mac table. > > > > > > This will work if only 1mac is behind 1 nic, so it should be an > > > option > > > (nested hypervisor for examples). > > > > > > but for classic vm , it could allow to disable unicast_flood && > > > learning for the tap interface, but also promisc mode on tap > > > interface! > > > > > > I was think about add an option on vmbrX  or vnetX directly to > > > enable/disable. > > > > As this would be on the VM tap devices it would sound somewhat > > reasonable to > > have it as per vNIC setting, but naturally it would then be a bit > > annoying to > > change for all; a tradeoff could be to allow setting the default > > value per > > bridge, node or datacenter (I'd do only one of those). > > > > What do you think? > > > I have done test, I think the best way is to enable it on the bridge >  or vnet for sdn. > because ovs don't support it for example, or its not needed for routed > setup or vxlan. > I don't known too much where add this option for classic vmbr ? in > /etc/network/interfaces ?. > I can't reuse bridge-unicast-flood off, bridge-learning off on vmbr > with ifupdown, because it's apply on all ports (ethX), and we don't > want that. > I could add a custom attribute, but I need to parse > /etc/network/interfaces in this case  for the tap_plug sub.  As far as I can tell, ifupdown2 only applies this to the ports it knows about, so in theory we *could* start to honor this for the interfaces we crate for VMs as a default, and have an on/off/auto value on VM network interfaces (override or use whatever /e/n/interfaces says). Or do you mean you typically want this to be on for VMs but off specifically for the physical port? Then /e/n/interfaces won't fit. Although it *does* allow listing ports and doesn't seem to mind if a port does not exist, so we *may* get away with saying we expect something like this: bridge-unicast-flood eth0=on _pve=off Either way, it's a port setting, so I wonder a by-vm-interface optional override probably makes sense, not sure (but would be easy enough to do).