From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EFFBD6094A for ; Thu, 13 Jan 2022 12:04:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E24EA1D13F for ; Thu, 13 Jan 2022 12:04:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5E8B21D10A for ; Thu, 13 Jan 2022 12:04:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2926C46B1D for ; Thu, 13 Jan 2022 12:04:10 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 13 Jan 2022 12:03:59 +0100 Message-Id: <20220113110405.67232-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.137 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [abstractconfig.pm, snapshot-test.pm, qemuconfig.pm, config.pm] Subject: [pve-devel] [PATCH-SERIES v2 guest-common/qemu-server/container] activate storages for snapshot operations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jan 2022 11:04:42 -0000 to make it work when the storage is just not active yet, and have early errors when the storage cannot be activated. Also prohibits snapshot operations when an involved storage is disabled, but otherwise available. Both qemu-server and pve-container build-depend upon pve-guest-common for the added tests. Changes from v1: * Rebase on current master. guest-common: Fabian Ebner (2): config: remove unused variable config: activate affected storages for snapshot operations src/PVE/AbstractConfig.pm | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) qemu-server: Fabian Ebner (1): snapshot: implement __snapshot_activate_storages PVE/QemuConfig.pm | 19 +++++++++++ .../create/qemu-server/303.conf | 13 +++++++ .../delete/qemu-server/204.conf | 33 ++++++++++++++++++ .../rollback/qemu-server/303.conf | 34 +++++++++++++++++++ .../create/qemu-server/303.conf | 13 +++++++ .../delete/qemu-server/204.conf | 33 ++++++++++++++++++ .../rollback/qemu-server/303.conf | 34 +++++++++++++++++++ test/snapshot-test.pm | 32 +++++++++++++++++ 8 files changed, 211 insertions(+) create mode 100644 test/snapshot-expected/create/qemu-server/303.conf create mode 100644 test/snapshot-expected/delete/qemu-server/204.conf create mode 100644 test/snapshot-expected/rollback/qemu-server/303.conf create mode 100644 test/snapshot-input/create/qemu-server/303.conf create mode 100644 test/snapshot-input/delete/qemu-server/204.conf create mode 100644 test/snapshot-input/rollback/qemu-server/303.conf container: Fabian Ebner (3): config: snapshot_delete_remove_drive: check for parsed value config: parse_volume: don't die when noerr is set snapshot: implement __snapshot_activate_storages src/PVE/LXC/Config.pm | 25 +++++++++++++-- .../snapshot-expected/create/lxc/204.conf | 10 ++++++ .../snapshot-expected/delete/lxc/204.conf | 25 +++++++++++++++ .../snapshot-expected/rollback/lxc/209.conf | 29 +++++++++++++++++ src/test/snapshot-input/create/lxc/204.conf | 10 ++++++ src/test/snapshot-input/delete/lxc/204.conf | 25 +++++++++++++++ src/test/snapshot-input/rollback/lxc/209.conf | 29 +++++++++++++++++ src/test/snapshot-test.pm | 32 +++++++++++++++++++ 8 files changed, 183 insertions(+), 2 deletions(-) create mode 100644 src/test/snapshot-expected/create/lxc/204.conf create mode 100644 src/test/snapshot-expected/delete/lxc/204.conf create mode 100644 src/test/snapshot-expected/rollback/lxc/209.conf create mode 100644 src/test/snapshot-input/create/lxc/204.conf create mode 100644 src/test/snapshot-input/delete/lxc/204.conf create mode 100644 src/test/snapshot-input/rollback/lxc/209.conf -- 2.30.2