From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0A3136098E for ; Tue, 11 Jan 2022 11:26:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ED2551CC3A for ; Tue, 11 Jan 2022 11:26:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7A92D1CC31 for ; Tue, 11 Jan 2022 11:26:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B69846C45 for ; Tue, 11 Jan 2022 11:26:22 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 11 Jan 2022 11:26:21 +0100 Message-Id: <20220111102621.2443645-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.164 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: fix novnc scaling radio buttons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 10:26:53 -0000 when having selected 'off', the next start of the window has both radiobuttons selected and no change is possible anymore. It seems that the 'checked: true' triggers only after the 'init' function. So instead remove the 'checked: true', and add the default in the init function. Signed-off-by: Dominik Csapak --- www/manager6/window/Settings.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/www/manager6/window/Settings.js b/www/manager6/window/Settings.js index 4aa7137c..b151adcd 100644 --- a/www/manager6/window/Settings.js +++ b/www/manager6/window/Settings.js @@ -34,10 +34,8 @@ Ext.define('PVE.window.Settings', { var username = sp.get('login-username') || Proxmox.Utils.noneText; me.lookupReference('savedUserName').setValue(Ext.String.htmlEncode(username)); - var vncMode = sp.get('novnc-scaling'); - if (vncMode !== undefined) { - me.lookupReference('noVNCScalingGroup').setValue({ noVNCScalingField: vncMode }); - } + var vncMode = sp.get('novnc-scaling') || 'scale'; + me.lookupReference('noVNCScalingGroup').setValue({ noVNCScalingField: vncMode }); let summarycolumns = sp.get('summarycolumns', 'auto'); me.lookup('summarycolumns').setValue(summarycolumns); @@ -379,7 +377,6 @@ Ext.define('PVE.window.Settings', { name: 'noVNCScalingField', inputValue: 'scale', boxLabel: 'Local Scaling', - checked: true, }, { xtype: 'radiofield', name: 'noVNCScalingField', -- 2.30.2