From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C05CD85853 for ; Mon, 20 Dec 2021 13:43:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF6E51CDF4 for ; Mon, 20 Dec 2021 13:43:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2497B1CDE9 for ; Mon, 20 Dec 2021 13:43:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EEBB744F27 for ; Mon, 20 Dec 2021 13:43:10 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 20 Dec 2021 13:43:10 +0100 Message-Id: <20211220124310.3943121-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.168 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] status: influxdb: suppress warning when no token exists X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 12:43:42 -0000 in get_credentials, we try to read the token for the specified server, and warn if we cannot do that (e.g. because the file does not exist) since having no token is a valid configuration, suppress that warning on connection. reported by a forum-user: https://forum.proxmox.com/threads/interface-comes-up-with-all-question-marks.83287/page-2#post-438204 Signed-off-by: Dominik Csapak --- alternatively, we could create an empty file on creation, but this does not fix existing installations. PVE/Status/InfluxDB.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Status/InfluxDB.pm b/PVE/Status/InfluxDB.pm index cb788c4e..def7e2fd 100644 --- a/PVE/Status/InfluxDB.pm +++ b/PVE/Status/InfluxDB.pm @@ -225,7 +225,7 @@ sub _connect { return $socket; } elsif ($proto =~ m/^https?$/) { - my $token = get_credentials($id); + my $token = get_credentials($id, 1); my $org = $cfg->{organization} // 'proxmox'; my $bucket = $cfg->{bucket} // 'proxmox'; my $url = _get_v2url($cfg, "write?org=${org}&bucket=${bucket}"); -- 2.30.2