From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 08E9C858F6 for ; Mon, 20 Dec 2021 12:38:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE8D71BFE9 for ; Mon, 20 Dec 2021 12:37:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7AE161BFD5 for ; Mon, 20 Dec 2021 12:37:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B9F044CFB for ; Mon, 20 Dec 2021 12:37:58 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 20 Dec 2021 12:37:57 +0100 Message-Id: <20211220113757.3150847-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.169 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve_flutter_frontend] workaround for novnc fullscreen behaviour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 11:38:29 -0000 since the webview seemingly does not allow javascripts 'requestFullscreen', workaround that by making the whole webview fullscreen and hiding novncs fullscreen button Signed-off-by: Dominik Csapak --- lib/widgets/pve_console_menu_widget.dart | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/widgets/pve_console_menu_widget.dart b/lib/widgets/pve_console_menu_widget.dart index 2cd2bc9..17573d6 100644 --- a/lib/widgets/pve_console_menu_widget.dart +++ b/lib/widgets/pve_console_menu_widget.dart @@ -180,13 +180,11 @@ class PveConsoleMenu extends StatelessWidget { Route _createHTMLConsoleRoute() { return PageRouteBuilder( - pageBuilder: (context, animation, secondaryAnimation) => Card( - child: PVEWebConsole( - apiClient: apiClient, - node: node, - guestID: guestID, - type: type, - ), + pageBuilder: (context, animation, secondaryAnimation) => PVEWebConsole( + apiClient: apiClient, + node: node, + guestID: guestID, + type: type, ), ); } @@ -219,7 +217,7 @@ class PVEWebConsoleState extends State { final ticket = widget.apiClient.credentials.ticket!; final baseUrl = widget.apiClient.credentials.apiBaseUrl; - var consoleUrl = "${baseUrl}/?novnc=1&node=${widget.node}&resize=scale"; + var consoleUrl = "${baseUrl}/?novnc=1&node=${widget.node}&isFullscreen=true&resize=scale"; if (widget.guestID != null) { final consoleType = widget.type == 'lxc' ? 'lxc' : 'kvm'; consoleUrl += "&console=${consoleType}&vmid=${widget.guestID}"; -- 2.30.2