From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A29B184F32 for ; Thu, 16 Dec 2021 13:13:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 771A81E4AE for ; Thu, 16 Dec 2021 13:12:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3625B1E44F for ; Thu, 16 Dec 2021 13:12:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E64245316 for ; Thu, 16 Dec 2021 13:12:38 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 16 Dec 2021 13:12:23 +0100 Message-Id: <20211216121233.162288-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211216121233.162288-1-f.ebner@proxmox.com> References: <20211216121233.162288-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.155 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm, pbsplugin.pm] Subject: [pve-devel] [PATCH storage 1/2] list volumes: also return backup type for backups X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Dec 2021 12:13:10 -0000 Otherwise, there is no storage-agnostic way to filter by backup group. Call it subtype, to not confuse it with content type, and to be able to re-use it for other content types than backup, if the need ever arises. Signed-off-by: Fabian Ebner --- PVE/Storage/PBSPlugin.pm | 1 + PVE/Storage/Plugin.pm | 1 + test/list_volumes_test.pm | 10 ++++++++++ 3 files changed, 12 insertions(+) diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm index e186663..4b3f349 100644 --- a/PVE/Storage/PBSPlugin.pm +++ b/PVE/Storage/PBSPlugin.pm @@ -688,6 +688,7 @@ sub list_volumes { content => 'backup', vmid => int($bid), ctime => $epoch, + subtype => $btype eq 'vm' ? 'qemu' : 'lxc', # convert to PVE backup type }; $info->{verification} = $item->{verification} if defined($item->{verification}); diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index 12f1b4b..0a6c619 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -1160,6 +1160,7 @@ my $get_subdir_files = sub { my $archive_info = eval { PVE::Storage::archive_info($fn) } // {}; $info->{ctime} = $archive_info->{ctime} if defined($archive_info->{ctime}); + $info->{subtype} = $archive_info->{type} // 'unknown'; if (defined($vmid) || $fn =~ m!\-([1-9][0-9]{2,8})\-[^/]+\.${format}$!) { $info->{vmid} = $vmid // $1; diff --git a/test/list_volumes_test.pm b/test/list_volumes_test.pm index ac75c04..d155cb9 100644 --- a/test/list_volumes_test.pm +++ b/test/list_volumes_test.pm @@ -133,6 +133,7 @@ my @tests = ( 'ctime' => 1585602700, 'format' => 'vma.gz', 'size' => DEFAULT_SIZE, + 'subtype' => 'qemu', 'vmid' => '16110', 'volid' => 'local:backup/vzdump-qemu-16110-2020_03_30-21_11_40.vma.gz', }, @@ -141,6 +142,7 @@ my @tests = ( 'ctime' => 1585602765, 'format' => 'vma.lzo', 'size' => DEFAULT_SIZE, + 'subtype' => 'qemu', 'vmid' => '16110', 'volid' => 'local:backup/vzdump-qemu-16110-2020_03_30-21_12_45.vma.lzo', }, @@ -149,6 +151,7 @@ my @tests = ( 'ctime' => 1585602835, 'format' => 'vma', 'size' => DEFAULT_SIZE, + 'subtype' => 'qemu', 'vmid' => '16110', 'volid' => 'local:backup/vzdump-qemu-16110-2020_03_30-21_13_55.vma', }, @@ -157,6 +160,7 @@ my @tests = ( 'ctime' => 1585602835, 'format' => 'vma.zst', 'size' => DEFAULT_SIZE, + 'subtype' => 'qemu', 'vmid' => '16110', 'volid' => 'local:backup/vzdump-qemu-16110-2020_03_30-21_13_55.vma.zst', }, @@ -202,6 +206,7 @@ my @tests = ( 'ctime' => 1585604370, 'format' => 'tar.lzo', 'size' => DEFAULT_SIZE, + 'subtype' => 'lxc', 'vmid' => '16112', 'volid' => 'local:backup/vzdump-lxc-16112-2020_03_30-21_39_30.tar.lzo', }, @@ -210,6 +215,7 @@ my @tests = ( 'ctime' => 1585604970, 'format' => 'tar.gz', 'size' => DEFAULT_SIZE, + 'subtype' => 'lxc', 'vmid' => '16112', 'volid' => 'local:backup/vzdump-lxc-16112-2020_03_30-21_49_30.tar.gz', }, @@ -218,6 +224,7 @@ my @tests = ( 'ctime' => 1585604970, 'format' => 'tar.zst', 'size' => DEFAULT_SIZE, + 'subtype' => 'lxc', 'vmid' => '16112', 'volid' => 'local:backup/vzdump-lxc-16112-2020_03_30-21_49_30.tar.zst', }, @@ -226,6 +233,7 @@ my @tests = ( 'ctime' => 1585605570, 'format' => 'tgz', 'size' => DEFAULT_SIZE, + 'subtype' => 'lxc', 'vmid' => '16112', 'volid' => 'local:backup/vzdump-lxc-16112-2020_03_30-21_59_30.tgz', }, @@ -368,6 +376,7 @@ my @tests = ( 'ctime' => 1580759863, 'format' => 'tar.gz', 'size' => DEFAULT_SIZE, + 'subtype' => 'lxc', 'vmid' => '19253', 'volid' => 'local:backup/vzdump-lxc-19253-2020_02_03-19_57_43.tar.gz', }, @@ -376,6 +385,7 @@ my @tests = ( 'ctime' => 1548098959, 'format' => 'tar', 'size' => DEFAULT_SIZE, + 'subtype' => 'lxc', 'vmid' => '19254', 'volid' => 'local:backup/vzdump-lxc-19254-2019_01_21-19_29_19.tar', }, -- 2.30.2