From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2E3F484185 for ; Fri, 10 Dec 2021 18:33:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1CF1C299BD for ; Fri, 10 Dec 2021 18:33:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4ED4B299AF for ; Fri, 10 Dec 2021 18:33:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 12FE945134 for ; Fri, 10 Dec 2021 18:33:12 +0100 (CET) Date: Fri, 10 Dec 2021 18:33:09 +0100 From: Stoiko Ivanov To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: <20211210183309.133c4b3a@rosa.proxmox.com> In-Reply-To: References: <20211210164947.3138643-1-s.ivanov@proxmox.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.281 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [control.in, proxmox.com] Subject: Re: [pve-devel] [PATCH pve-kernel] fix #3781: add Provides: wireguard-modules to control.in X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 17:33:43 -0000 On Fri, 10 Dec 2021 18:27:39 +0100 Thomas Lamprecht wrote: > On 10.12.21 17:49, Stoiko Ivanov wrote: > > without this line `apt install wireguard` pulls in Debian's kernel + > > firmware which confilcts with pve-firmware - forcing users to install > > via `apt install --no-install-recommends wireguard-tools` in order > > to get the userspace utils. > > > > For Debian's upstream kernel the linux-image-amd64 provides the > > modules [0] - since pve-kernel-@KVNAME@ already provides linux-image > > this should be the place where we add the provides > > > > versioned dependency added since wireguard has a versioned dependency > > on wireguard-modules. > > > > [0] https://salsa.debian.org/kernel-team/linux/-/blob/master/debian/templates/control.image.meta.in > > did we actually had users run into this? I'm probably way to accustomed to > just installing `wireguard-tools` that I never even noticed that there's a > meta package - I mean wireguard got mainlined with 5.6, that was released on > 2020-01-26, so rather ancient ;-P > > anyhow, lgtm well - at least the reporter in: https://bugzilla.proxmox.com/show_bug.cgi?id=3781 also - when installing `wireguard-tools` on a (slightly older) VM of mine it tries to pull in `apparmor linux-image-5.10.0-9-rt-amd64 linux-image-rt-amd64 wireguard-tools` (since wireguard-tools Recommends wireguard-modules) not a problem per se - but ever since the few reports of people uninstalling pve-kernel (since linux-image-amd64 started depending on linux-firmware, which uninstalled pve-firmware) - I'm a bit weary of keeping Debian's stock kernel installed in parallel (my first draft for this report was also - marking it as RESOVLED WORKSFORME though ;)