From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9FC6583168 for ; Thu, 2 Dec 2021 12:43:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 932B618E5B for ; Thu, 2 Dec 2021 12:43:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2770618E52 for ; Thu, 2 Dec 2021 12:43:16 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ED2014444E for ; Thu, 2 Dec 2021 12:43:15 +0100 (CET) From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Thu, 2 Dec 2021 12:43:03 +0100 Message-Id: <20211202114303.350940-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.715 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2] apply pending changes at vm stop only if the section is not empty X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2021 11:43:16 -0000 we also have the same skipping logic when starting vms, this way we avoid calling 'write_config' when there are no present changes to commit. Signed-off-by: Oguz Bektas --- v1->v2: * keep using the hardcoded 1 for vm_stop_cleanup call since we do an early return anyway PVE/QemuServer.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 45b704d..0071a06 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4998,6 +4998,8 @@ sub vmconfig_delete_or_detach_drive { sub vmconfig_apply_pending { my ($vmid, $conf, $storecfg, $errors) = @_; + return if !scalar(keys %{$conf->{pending}}); + my $add_apply_error = sub { my ($opt, $msg) = @_; my $err_msg = "unable to apply pending change $opt : $msg"; -- 2.30.2