From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1575B830FC for ; Thu, 2 Dec 2021 12:00:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04BD01887C for ; Thu, 2 Dec 2021 12:00:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8F1FD1885C for ; Thu, 2 Dec 2021 12:00:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 55AC544D94 for ; Thu, 2 Dec 2021 12:00:09 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 2 Dec 2021 12:00:05 +0100 Message-Id: <20211202110005.38699-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211202110005.38699-1-f.ebner@proxmox.com> References: <20211202110005.38699-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.163 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC manager 3/3] vzdump: new: add reminder to get rid of duplicate activate_storage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2021 11:00:41 -0000 While it's unlikely that something breaks in practice, because pvestatd calls activate_storage() for enabled storages every few seconds, there's no rush to remove the duplicate call. What could require the storage to be active between the activation in new() and the activation in exec_backup() is: 1. An external storage plugin that requires the storage to be active for its get_subdir() implementation (unlikely to exist). 2. A job-start hook-script that requires the storage to be active. Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 8c70906d..4a28e74f 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -501,6 +501,7 @@ sub new { if ($opts->{storage}) { my $storage_cfg = PVE::Storage::config(); + # FIXME: remove for PVE 8.0 # Ignore errors here. exec_backup will die if activation fails there. eval { PVE::Storage::activate_storage($storage_cfg, $opts->{storage}) }; -- 2.30.2