From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1460F830FB for ; Thu, 2 Dec 2021 12:00:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 029821887B for ; Thu, 2 Dec 2021 12:00:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8EC411885B for ; Thu, 2 Dec 2021 12:00:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 52AA744DB6 for ; Thu, 2 Dec 2021 12:00:09 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 2 Dec 2021 12:00:04 +0100 Message-Id: <20211202110005.38699-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211202110005.38699-1-f.ebner@proxmox.com> References: <20211202110005.38699-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.163 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC manager 2/3] vzdump: exec_backup: pick up latest version of storage.cfg after job-start hook X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2021 11:00:41 -0000 Without this, a storage that is enabled during the job-start hook would still be seen as disabled. Signed-off-by: Fabian Ebner --- Makes sense in the context of #3476, so that the storage that is only online e.g. once a day doesn't need to be kept enabled. But it also means that we have to be careful not to assert that a storage is enabled before the pre-start hook in the future. PVE/VZDump.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 667c92d3..8c70906d 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -1165,6 +1165,7 @@ sub exec_backup { $self->run_hook_script ('job-start', undef, $job_start_fd); + PVE::Cluster::cfs_update(); # Pick up eventual changes made by the hook script. my $storage_cfg = PVE::Storage::config(); # activating after job-start hook, so it has a chance to prepare, e.g. wake up remote node. -- 2.30.2