From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C1E7D82D01 for ; Wed, 1 Dec 2021 10:58:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B8930A7FE for ; Wed, 1 Dec 2021 10:57:58 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id F0487A7F3 for ; Wed, 1 Dec 2021 10:57:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CA86A435C2 for ; Wed, 1 Dec 2021 10:57:57 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Wed, 1 Dec 2021 10:57:48 +0100 Message-Id: <20211201095748.1064982-2-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211201095748.1064982-1-f.gruenbichler@proxmox.com> References: <20211201095748.1064982-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.252 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] [PATCH master/5.13 kernel 2/2] KConfig: disable module BTF debug info X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Dec 2021 09:58:28 -0000 enabling this effectively makes the debug info of the kernel image part of the kernel <-> module ABI[0], potentially breaking module loading for otherwise compatible kernel/module combinations. there were several user reports[1,2,3,..], and although a workaround exists (re-installing the currently booted version, loading the module, then upgrading again) disabling this until it's clear how to proceed seems like the way to go. disabling via patch is needed, since leaving it unset via `-d` or explicitly disabled via `--set-val` doesn't work - it's auto-enabled based on build-env pahole supporting split BTF generation. 0: https://lore.kernel.org/all/1637926692.uyvrkty41j.astroid@nora.none/ 1: https://forum.proxmox.com/threads/realtek-8156-2-5gbe-usb-nic.69903/#post-433793 2: https://forum.proxmox.com/threads/usb-storage-can-not-be-mounted.100480/ 3: https://forum.proxmox.com/threads/neuer-server-und-probleme.99098/#post-427862 Signed-off-by: Fabian Grünbichler --- patch number is different depending on branch (11 for 5.13, 9 for master), but patch applies as-is to both. note that disabling BTF for modules implies an ABI bump, as there is some conditional compilation based on that KConfig value.. patches/kernel/0012-disable-split-btf.patch | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 patches/kernel/0012-disable-split-btf.patch diff --git a/patches/kernel/0011-disable-split-btf.patch b/patches/kernel/0011-disable-split-btf.patch new file mode 100644 index 0000000..3f3a498 --- /dev/null +++ b/patches/kernel/0011-disable-split-btf.patch @@ -0,0 +1,13 @@ +diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug +index 25dc20175bba..7ff51a3f65e6 100644 +--- a/lib/Kconfig.debug ++++ b/lib/Kconfig.debug +@@ -314,7 +314,7 @@ config PAHOLE_HAS_SPLIT_BTF + def_bool $(success, test `$(PAHOLE) --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/'` -ge "119") + + config DEBUG_INFO_BTF_MODULES +- def_bool y ++ def_bool n + depends on DEBUG_INFO_BTF && MODULES && PAHOLE_HAS_SPLIT_BTF + help + Generate compact split BTF type information for kernel modules. -- 2.30.2