From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4175381DAC for ; Fri, 26 Nov 2021 11:19:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 32E3516993 for ; Fri, 26 Nov 2021 11:19:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5A00316979 for ; Fri, 26 Nov 2021 11:19:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 314F444757 for ; Fri, 26 Nov 2021 11:19:39 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 26 Nov 2021 11:19:38 +0100 Message-Id: <20211126101938.3992163-3-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211126101938.3992163-1-a.lauterer@proxmox.com> References: <20211126101938.3992163-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.093 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm] Subject: [pve-devel] [PATCH container 2/2] apply_pending_mountpoint: deactivate volumes if not running X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2021 10:19:40 -0000 Container volumes need to be activated to be formatted. Not deactivating them afterwards, if the container is not currently running, can lead to problems. For example RBD images will get mapped by krbd but not unmapped afterwards. Reassigning an MP to another CT right after would then lead to a mapping that needs to be unmapped manually with `rbd unmap` or by rebooting the node. Signed-off-by: Aaron Lauterer --- src/PVE/LXC/Config.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 1e28a88..ddfeed8 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1456,6 +1456,8 @@ sub apply_pending_mountpoint { $conf->{pending}->{$opt} = $original_value; die $err; } + } else { + PVE::Storage::deactivate_volumes($storecfg, $vollist); } } else { die "skip\n" if $running && defined($old); # TODO: "changing" mount points? -- 2.30.2